Bug #31522

ReflectionService prevents model from extending abstract base model without repository

Added by Marc Neuhaus over 1 year ago. Updated 10 months ago.

Status:Resolved Start date:2011-11-02
Priority:Must have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:Reflection
Target version:TYPO3 Flow Base Distribution - 1.1 RC2
PHP Version: Complexity:
Has patch:Yes FLOW3 version affected:FLOW3 1.0.0
Votes: 0

Description

Hey!

i ran into some difficulties with using a base class for my models. The "ensureAggregateRootInheritanceChainConsistency" function of the ReflectionService prevents me from extending my Models from another class.

I attached a diff to allow the extending from abstract classes.

Greetings Marc

ReflectionService.diff (575 Bytes) Marc Neuhaus, 2011-11-02 20:10

Associated revisions

Revision 2d62b1e8
Added by Karsten Dambekalns 11 months ago

[BUGFIX] Skip abstract classes in ensureAggregateRootInheritanceChainConsistency

When using an abstract base class for domain models, the checks done in
ensureAggregateRootInheritanceChainConsistency() would fail, even though
it is fine to have an abstract base class not being aggregate root.

Change-Id: I51d33c69be577ce0d1c0f663042c0de5ec6109e7
Fixes: #31522
Releases: 1.0, 1.1, 1.2

Revision c01cc4a2
Added by Karsten Dambekalns 10 months ago

[BUGFIX] Skip abstract classes in ensureAggregateRootInheritanceChainConsistency

When using an abstract base class for domain models, the checks done in
ensureAggregateRootInheritanceChainConsistency() would fail, even though
it is fine to have an abstract base class not being aggregate root.

Change-Id: I51d33c69be577ce0d1c0f663042c0de5ec6109e7
Fixes: #31522
Releases: 1.0, 1.1, 1.2

History

#1
Updated by Marc Neuhaus over 1 year ago

As jwa pointed out in irc i could try it with "@ORM\InheritanceType("JOINED")" but i don't want a table for my abstract class.

i tried to use "@ORM\InheritanceType("SINGLE_TABLE")" but it throws me the error "Base table or view not found: 1146 Table 'flow3.admin_core_model' doesn't exist"

Greetings Marc

#2
Updated by Karsten Dambekalns over 1 year ago

  • Target version changed from 1.0.1 to 1.0.2

#3
Updated by Karsten Dambekalns over 1 year ago

  • Status changed from New to Accepted

#4
Updated by Karsten Dambekalns over 1 year ago

  • Target version changed from 1.0.2 to 1.0.3

#5
Updated by Karsten Dambekalns about 1 year ago

  • Target version changed from 1.0.3 to 1.0.4

#6
Updated by Karsten Dambekalns about 1 year ago

  • Target version changed from 1.0.4 to 1.0.5

#7
Updated by Karsten Dambekalns 12 months ago

  • Target version changed from 1.0.5 to 1.1 RC1

#8
Updated by Karsten Dambekalns 11 months ago

  • Subject changed from ReflectionService prevents extending Models from other Models to ReflectionService prevents model from extending abstract base model without repository

#9
Updated by Gerrit Code Review 11 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12361

#10
Updated by Karsten Dambekalns 11 months ago

  • Target version changed from 1.1 RC1 to 1.1

#11
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12361

#12
Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12589

#13
Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/12590

#14
Updated by Karsten Dambekalns 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15
Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12589

#16
Updated by Karsten Dambekalns 10 months ago

  • Status changed from Under Review to Resolved
  • Target version changed from 1.1 to 1.1 RC2

Also available in: Atom PDF