Bug #31771: Wrong "targetDomain" in tslib_cObj::typolink with sys_domain records and different url sheme - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #31771

closed

Wrong "targetDomain" in tslib_cObj::typolink with sys_domain records and different url sheme

Added by Jaume Prat over 12 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

4.5.11

Start date:

2011-11-12

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

5.3

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

If you generate a link with "tslib_cObj::typolink" to a page which has a different domain, typolink() loads the matching domain from sys_domain. But if the target page has a different url scheme (set in page settings) than the current rendered page, then always the current domain will be used!

You can find this issue in line 5788-5792 in "class.tslib_content.php":

// If no domain records are defined, use current domain:
if ($targetDomain === '' && $conf['forceAbsoluteUrl'] ||
        $absoluteUrlScheme !== parse_url(t3lib_div::getIndpEnv('TYPO3_REQUEST_URL'), PHP_URL_SCHEME)) {
    $targetDomain = $currentDomain;
}

You have to check for a empty $targetDomain if the target-scheme is different too! Otherwise the correct targetDomain will always be overwritten with the current domain:

You can fix it with some braces to check always for a empty targetDomain:

// If no domain records are defined, use current domain:
if ($targetDomain === '' && ($conf['forceAbsoluteUrl'] ||
        $absoluteUrlScheme !== parse_url(t3lib_div::getIndpEnv('TYPO3_REQUEST_URL'), PHP_URL_SCHEME))) {
    $targetDomain = $currentDomain;
}

Actions

Copy link

Updated by Steffen Ritter over 12 years ago

Status changed from New to Accepted

I know about it - stumbled across it myself...
Problem is: we would need a systematic rewrite of the typolink function...

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

But that's such an obvious bug that has to be fixed - independent of a rewrite of typolink.

Actions

Copy link

Updated by Steffen Ritter over 12 years ago

Steffen Gebert wrote:

But that's such an obvious bug that has to be fixed - independent of a rewrite of typolink.

if you see no side effects... I fear about them...
It seems obvious, aber there must have been a reason, to do it like it has been done...

This should be tested in complex multi-domain installations for some time before including it into an release? don't you think so?

Could you give it a try at the FW sites? I would test it within the instances I had the problem myself hoping nothing else would break.

Actions

Copy link

Updated by Dmitry Dulepov over 12 years ago

The proposed change would not work in all cases. The next lines are:

// If go for an absolute link, add site_path if it's not taken care about by absRefPrefix
if (!$GLOBALS['TSFE']->config['config']['absRefPrefix'] && $targetDomain !== '') {
    $targetDomain = $currentDomain . rtrim(t3lib_div::getIndpEnv('TYPO3_SITE_PATH'), '/');
}

So the target domain will be overwritten by the current domain if absRefPrefix is not set.

Actions

Copy link