Bug #31773

Query Parameter "_" triggers Notice "Uninitialized string offset: 1"

Added by Johannes K over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2011-11-12
Priority:Should have Due date:
Assignee:Johannes K % Done:

100%
Category:MVC
Target version:TYPO3 Flow Base Distribution - 1.0.1
PHP Version: Complexity:no-brainer
Has patch:Yes FLOW3 version affected:FLOW3 1.0.0
Votes: 0

Description

If FLOW3 gets a Request with a parameter named "_" the code check for an internal argument in TYPO3\FLOW3\MVC\Web\Request::setArgument() fails with a PHP Notice: Uninitialized string offset: 1 in line 362

http://flow3.localhost/?_=123

This happens e.g. in jQuery ajax calls do to avoid caching

Associated revisions

Revision 69f35424
Added by Johannes K over 1 year ago

[BUGFIX] Allow usage of query parameter "_"

Assert that the length of $argumentName is >= 2 before accessing it at
position 1

Fixes: #31773
Releases: 1.0, 1.1
Change-Id: I87927e66831c20f06acfa506c9e222635faa33b2

Revision dfebde27
Added by Johannes K over 1 year ago

[BUGFIX] Allow usage of query parameter "_"

Assert that the length of $argumentName is >= 2 before accessing it at
position 1

Change-Id: I1287df30e859a989d7edbef62d4c803bcb4cfde1
Fixes: #31773
Releases: 1.0, 1.1

History

#1
Updated by Bastian Waidelich over 1 year ago

  • Status changed from New to Accepted

Good catch! Should I take care?

#2
Updated by Mr. Hudson over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 of change I87927e66831c20f06acfa506c9e222635faa33b2 has been pushed to the review server.
It is available at http://review.typo3.org/6641

#3
Updated by Johannes K over 1 year ago

Too late ;)

#4
Updated by Mr. Hudson over 1 year ago

Patch set 2 of change I87927e66831c20f06acfa506c9e222635faa33b2 has been pushed to the review server.
It is available at http://review.typo3.org/6641

#5
Updated by Mr. Hudson over 1 year ago

Patch set 3 of change I87927e66831c20f06acfa506c9e222635faa33b2 has been pushed to the review server.
It is available at http://review.typo3.org/6641

#6
Updated by Johannes K over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF