Bug #32061
Localized media relations: DAM elements cant be overwritten
| Status: | Resolved | Start date: | 2011-11-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Georg Ringer | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| TYPO3 Version: | 4.7 | Has patch: | No | |
| PHP Version: | Complexity: | |||
| Votes: | 0 |
Description
When using DAM media relations its not possible to overwrite the original (default language) DAM record. When using simple image files its possible to overwrite the file. This is useful for example when using an image which includes text.
The problem is caused by using the original language media relation records uid within the DamViewHelper (in function tx_dam_db::getReferencedFiles). This problem could be solved by adding a getter for localized uid to extbase, so we would be able to use the correct uid and receive the translated (overlay) image.
Associated revisions
[BUGFIX] Improve handling of DAM and translations
Change-Id: I0c061f1312a6ec8d7f47e45bfa93c3e841fcac3e
Resolves: #32061
Reviewed-on: https://review.typo3.org/18382
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
Updated by Georg Ringer over 1 year ago
- Status changed from New to Accepted
- Assignee set to Georg Ringer
I didnt know that dam can be translated already..
Updated by Felix Nagel over 1 year ago
No, DAM records cant be translated yet (there is a pending patch but there is FAL, so I assume it wont be included in DAM).
Its not about localize DAM records, its about the localized media relations (within news) which could have a different DAM record attached than its original media relation record. Atm new DAM records could be attached but wont be rendered.
Updated by Felix Nagel 11 months ago
- TYPO3 Version changed from 4.6 to 4.7
Problem persists in TYPO3 4.7.1 :-(
Seems to be related to #32072 too.
Updated by Sengchheang Chhun 11 months ago
- File DamViewHelper.php.patch added
Hi,
I have this problem too and I patched DamViewHelper.php to check the overlay record of the provided media uid.
It is working for me now but I am not sure if this patch fits to this issue.
Could anyone give me any comments?
Thanks,
Sengchheang
Updated by Felix Nagel 10 months ago
This seems like a possible workaround as long as Extbase is not able to provide usable LL support. Ive tested this in a frech installation and it works pretty nice.
Its now possible to change the DAM relation added to the localized news record. Sadly this is no solution when trying to add more records to a localized (damn you extbase!) but it really helps if pictures include localized text. Thanks Sengchheang!
@Georg, I would recommend implement this as it makes news a little bit more usable!
Updated by Sengchheang Chhun 10 months ago
- File DamViewHelper.php.patch_v2 added
Felix Nagel wrote:
This seems like a possible workaround as long as Extbase is not able to provide usable LL support. Ive tested this in a frech installation and it works pretty nice. Its now possible to change the DAM relation added to the localized news record. Sadly this is no solution when trying to add more records to a localized (damn you extbase!) but it really helps if pictures include localized text. Thanks Sengchheang!
@Georg, I would recommend implement this as it makes news a little bit more usable!
Thanks for using my patch. :)
I think the option mergeIfNotBlank (of dam image field) does not work well in my previous patch.
So I've just uploaded another patch to fix this issue.
Please find my second patch in the attachment of this post.
Updated by Sengchheang Chhun 10 months ago
- File News.php.patch added
Felix Nagel wrote:
Sadly this is no solution when trying to add more records to a localized (damn you extbase!)
Oops! I forgot to post another patch when I uploaded my first patch. I also have this problem too.
Please find the patch for this problem in this comment.
Edit: I know it is just a workaround but it helps me to solve this problem.
Edit: Please use mediaOfIrre property like using media property in the fluid template and this property is not a replacement of media property. Just use it for the missing IRRE records of the translated news. Note: the sorting of media records in the translated news is not working.
Updated by Gerrit Code Review 3 months ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18382
Updated by Georg Ringer 3 months ago
- Status changed from Under Review to Resolved