CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #32064

Localized media relations: uses default language caption

Added by Felix Nagel over 1 year ago. Updated 3 months ago.

Status:Resolved Start date:2011-11-24
Priority:Should have Due date:
Assignee:Georg Ringer % Done:

100%

Category:Frontend
Target version:-
TYPO3 Version:4.6 Has patch:No
PHP Version: Complexity:
Votes: 0

Description

Currently news uses the default language caption if no caption is set in the localized media relation. This behavior should be controlled by standard TYPO3 language settings (strict, hideNonTranslated, ...).

Associated revisions

Revision d912707f
Added by Georg Ringer 3 months ago

[TASK] Change fields from mergeIfNotBlank to noCopy

Some fields should not be shown in the FE if those are
not field in the translation.

Change-Id: I24111815d7d1f6ad8cce608b4b0b3405ca46d67d
Resolves: #32064
Reviewed-on: https://review.typo3.org/18394
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

History

Updated by Georg Ringer over 1 year ago

  • Status changed from New to Accepted
  • Assignee set to Georg Ringer

Updated by Georg Ringer over 1 year ago

  • Status changed from Accepted to Needs Feedback

do you really want an em-configuration field for every field of every record type?

you can of course configure that in ext_tables.php of an extension loaded after ext:news and remove

'l10n_mode' => 'mergeIfNotBlank',

i just not know yet what the default behaviour is? should it be not merged from default language = empty in other languages?

Updated by Felix Nagel over 1 year ago

Sorry for the delay, we had a website launch this Monday.

No, an EM config for each field wouldnt be suitable. What about a general flag for multiple fields? Another solution would be just to add an info to the documentation.
In my opinion mergeIfNotBlank is not suitable. If English is default it would be ok, but in any other case it just looks like an error. I would prefer an empty string for non-translated captions.

I need to use the "crowbar" to get it working:

// wont work
unset($GLOBALS['TCA']['tx_news_domain_model_media']['columns']['caption']['l10n_mode'])
// works
t3lib_div::loadTCA('tx_news_domain_model_media');
unset($TCA['tx_news_domain_model_media']['columns']['caption']['l10n_mode']);

Just for satisfying my curiosity: Why does changing to 'noCopy' breaks the whole functionality?

Updated by Gerrit Code Review 3 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18394

Updated by Georg Ringer 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF