Core

Core Advanced Frontend Editing DBAL Extbase MVC Framework Fluid Indexed Search Linkvalidator Scheduler t3editor Team Resources Workspaces & Versioning Community Extensions Incubator Distributions TYPO3 4.5 Projects TYPO3 4.7 Projects TYPO3 6.0 Projects TYPO3 6.1 Projects TYPO3 6.2 Projects (+)

Bug #32161

Invalid SQL in the indexed_search

Added by Dmitry Dulepov over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Start date:

2011-11-29

Priority:

Should have

Due date:

Assignee:

% Done:

100%

Category:

Target version:

TYPO3 Version:

4.7

Complexity:

PHP Version:

Votes:

Description

!= should be <> in mod/index.php, function getPhashT3pages.

Related issues

related to DBAL - Bug #32626: not equal statement only works with != not with <>	Resolved	2011-12-16
related to Core - Bug #33697: Em extension list update is broken	Resolved	2012-02-06

Associated revisions

Revision 62b05fe9
Added by Stefan Neufeind over 1 year ago

[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6977
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 3aa0ca83
Added by Stefan Neufeind over 1 year ago

[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8900
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Revision 7d5bf8a3
Added by Stefan Neufeind over 1 year ago

[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8901
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1
Updated by Mr. Jenkins over 1 year ago

Status changed from New to Under Review

Patch set 1 of change If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd has been pushed to the review server.
It is available at http://review.typo3.org/6977

#2
Updated by Dmitry Dulepov over 1 year ago

...and in many other places too.

#3
Updated by Stefan Neufeind over 1 year ago

Just for reference, a discussion that != is usually supported on todays DBMS but <> is the standard-way (ANSI) to go:
http://stackoverflow.com/questions/723195/should-i-use-or-for-not-equal-in-tsql