Bug #32261
closed
mkdir_deep does not set correct permissions nor create group
100%
Description
t3lib_div::mkdir_deep does not use the provided fixPermissions function and fails to set proper permissions and ownership.
Problems occur with typo3temp/Cache (see also issue 31987) and with Extension Builder (issue 29369), but possibly at other places too.
mkdir_deep uses the recursive option to create multiple, nested directories with one php mkdir command, but is based on 2 wrong assumptions:
1. if you set permissions using mkdir('path/newdir/newsubdir', 0775, TRUE); then only newsubdir gets chmodded, not newdir
2. setting permissions using mkdir is limited by the users umask (which can set to umask(0) by php but that also has drawbacks)
Additionally, mkdir_deep does not set group ownership following $TYPO3_CONF_VARS['BE']['createGroup']
The supplied patch should (IMO) make use of the already existing methods t3lib_div::mkdir and fixPermissions
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review over 12 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review about 12 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review about 12 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/8637
Updated by Loek Hilgersom about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9da8fd3a3f7d4898134719c13ff3059a23436935.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9171
Updated by
Updated by Jigal van Hemert about 12 years ago
Todo: abandon patch for 4.5 and mark this issue as resolved.
Updated by Christian Kuhn over 11 years ago
- Status changed from Under Review to Resolved
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed