Bug #32292

Page within a mountpoint using "Show Content from Page" results in 503 header

Added by Patrick Broens over 1 year ago. Updated 3 months ago.

Status:Resolved Start date:2011-12-05
Priority:Must have Due date:
Assignee:Patrick Broens % Done:

100%
Category:Content Rendering
Target version:4.7.0-beta2
TYPO3 Version:4.7 Complexity:
PHP Version:5.3
Votes: 1 (View)

Description

Problem:
A page (A) within a mountpoint using "Show Content from Page" (B) (pages: content_from_pid) results in a 503 header with the message "The requested page didn't have a proper connection to the tree-root!".

When content_from_pid is used, the TSFE for the current object (page A) will be cloned to a temporary object in tslib:TSpagegen (page B). In this temporary object, the page id is set to "page A"->content_from_pid. However, the MP is not changed, and will have the MP of page A.

This results in a TSFE page object (Page B) with the wrong MP (From Page A).

Within this temporary object the rootline will be calculated, which will be empty, because of the wrong MP variable. This triggers the 503 header with the mentioned message.

Solution:
Clear the MP variable in the temporary TSFE object for page B.

Releases:
4.7, 4.6, 4.5

Associated revisions

Revision e0b5a760
Added by Patrick Broens about 1 year ago

[BUGFIX] Page within a mountpoint using Show Content from Page results in 503 header

When pages:content_from_pid is used, the TSFE for the current object will be cloned to a temporary object for the page to get the content from. In this temporary object, the id for the page will be changed to the contents of content_from_pid. However, the MP variable will not be changed.

This results in a TSFE object with the wrong MP variable connected to the id. Within this temporary object the rootline will be calculated, which will be empty, because of the wrong MP variable. This triggers the 503 header.

This bugfix fixes this by emptying the MP variable.

Change-Id: I380b33e6daf3d36a1799409f484cc2e75290681b
Fixes: #32292
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7071
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Stefan Neufeind
Tested-by: Steffen Ritter

Revision fae94905
Added by Patrick Broens about 1 year ago

[BUGFIX] Page within a mountpoint using Show Content from Page results in 503 header

When pages:content_from_pid is used, the TSFE for the current object will be cloned to a temporary object for the page to get the content from. In this temporary object, the id for the page will be changed to the contents of content_from_pid. However, the MP variable will not be changed.

This results in a TSFE object with the wrong MP variable connected to the id. Within this temporary object the rootline will be calculated, which will be empty, because of the wrong MP variable. This triggers the 503 header.

This bugfix fixes this by emptying the MP variable.

Change-Id: I380b33e6daf3d36a1799409f484cc2e75290681b
Fixes: #32292
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9543
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1
Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7071

#2
Updated by Oliver Hader over 1 year ago

  • Target version changed from 4.7.0-alpha2 to 4.7.0-alpha3

#3
Updated by Steffen Ritter over 1 year ago

  • Target version changed from 4.7.0-alpha3 to 4.7.0-beta1

#4
Updated by Steffen Ritter about 1 year ago

  • Target version changed from 4.7.0-beta1 to 4.7.0-beta2

#5
Updated by Patrick Broens about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9543

#7
Updated by Patrick Broens about 1 year ago

  • Status changed from Under Review to Resolved

#8
Updated by Marcus Schwemer 10 months ago

Hi,

I don't know whether I try to test it right. Here is my setup

- Root-Page
-- Page A (this page is of type mountpoint)
---- Page B (this is the page using "Show content from pid")
-- Page C (Content from this page is shown on Page B)

Is this right? Viewing page B in FE should produce an error in a unpatched version:

The requested page didn't have a proper connection to the tree-root!<br /><br />(Illegal Mount Point found in rootline)

The patch should solve this issue.

But it does not. Even in the current trunk I get this message. Because of the latter I am unsure whether my testing setup is correct.

Can you enlighten me?

Thx,
Marcus

#9
Updated by Michael 6 months ago

I've tested Mountpoints in a clean installation TYPO3 4.7.7 with PHP 5.3 (testversion on Mittwald, there are only 4 pages and one mount point: http://typo3.p179466.webspaceconfig.de/index.php?id=2) there is still the problem: Mount Point > Mounted Page shows me the "Illegal Mount Point found in rootline"
Mount Point -> This Page shows the content of the page and the menu of the "Mount Page".
I've tested this in many installations, it works only with a PHP 5.3.1 Version on an allincl-server.
To have a solution for this bug is important, cause we have a lot of mount points in our website of our university.

Greetings,
Michael

#10
Updated by Oliver Salzburg 6 months ago

Still happens in 4.7.7 for me

#11
Updated by Lars Messmer - comsolit AG 3 months ago

Still happens in 4.7.8 with realurl
without realurl it works fine, so maybe it is a realurl bug?

Also available in: Atom PDF