Bug #32342
https does not work
| Status: | Resolved | Start date: | 2011-12-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Francois Suter | % Done: | 100% |
|
| Category: | Incorrect JS Output | |||
| Target version: | 3.0.0 | |||
| Votes: | 0 |
Description
There is an error in the static TS template:
page {
includeJSFooterlibs {
rsgoogleanalytics = http://www.google-analytics.com/ga.js
rsgoogleanalytics.external = 1
}
}
[globalString = _SERVER|HTTPS=on]
page.includeJSlibs.rsgoogleanalytics = https://ssl.google-analytics.com/ga.js
[global]
Mind the difference between includeJSlibs and includeJSFooterlibs!
By the way, is there a docu when to use which of these (includeJSlibs, includeJSFooterlibs, includeJS, HeaderData, etc...)?
Associated revisions
History
Updated by Francois Suter about 1 year ago
- Category set to Incorrect JS Output
- Status changed from New to Accepted
- Assignee set to Francois Suter
- Target version set to 3.0.0
I just stumbled on that mistake again while checking the backwards-compatibility of the current v2 development branch. It is fixed in that branch in r59136.
I would rather not fix this in the current 1 branch, as we're really trying to get v2 out. It that ok with you? (note: this is just my answer, I haven't coordinated with Steffen on that topic).
Updated by Felix Nagel about 1 year ago
Depends on how long it will take to v2. Its just a little fix which should not have sideffects at all.
If theres another release before v2 is published, please include it.
Updated by Francois Suter about 1 year ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset r60350.