Project

General

Profile

Actions

Bug #32517

closed

t3lib_compressor set local filename to remote uri for external resources

Added by Morton Jonuschat over 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-12-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The compressor doesn't correctly handles files that are added as an external resource, for example using

page.includeJS {
jquery = http://ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js
jquery.external = 1
}

t3lib_compressor doesn't update the filename to the local copy after downloading the asset. This results in error messages similar to this one:

PHP Warning: filemtime(): stat failed for /var/www/Intro/http://ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js in /var/www/typo3_src-git/t3lib/class.t3lib_compressor.php line 295

A fix has been uploaded at https://review.typo3.org/#change,7127


Related issues 5 (0 open5 closed)

Related to TYPO3 Core - Bug #35687: createMergedFile failure on external linksClosed2012-04-04

Actions
Related to TYPO3 Core - Bug #52597: Compressor: Fetch external files correctlyRejected2013-10-07

Actions
Is duplicate of TYPO3 Core - Bug #31239: compressor doesn't resolves files linked with domainClosed2011-10-24

Actions
Has duplicate TYPO3 Core - Bug #34162: Merging CSS/JS files with absRefPrefix set causes PHP errorClosed2012-02-21

Actions
Has duplicate TYPO3 Core - Bug #35045: Compressor, external JS, problem in 4.7.0 beta2?Closed2012-03-20

Actions
Actions #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7127

Actions #2

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7127

Actions #3

Updated by Anonymous about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9469

Actions #5

Updated by Anonymous about 12 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9872

Actions #7

Updated by Anonymous about 12 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF