Feature #32776
Disabling uniquing recipients list
| Status: | Under Review | Start date: | 2011-12-22 | ||
|---|---|---|---|---|---|
| Priority: | Should have | Due date: | |||
| Assignee: | Xavier Perseguers | % Done: | 90% |
||
| Category: | - | ||||
| Target version: | 1.3.1 | ||||
| Votes: | 0 |
Description
Also many thanks for this extension. It's very useful to us.
Currently the reciepient list will be made unique by email, so that if there are two entries with the same e-mail, then only the first will be in the list.
I guess this is fine in most scenarioes, but in our setup this is not what is wanted.
We build a PLAINLIST list with some extra fields, which are added to the newsletter with extra markers.
So I could receive two newsletters to the same e-mail address, but with different content (depending on the content of the extra fields).
I will create a patch.
History
Updated by Stig Nørgaard Færch over 1 year ago
- File feature_32776.diff added
- % Done changed from 0 to 90
Here is the patch.
Updated by Xavier Perseguers over 1 year ago
- Status changed from New to Accepted
I agree with this feature, however may I kindly ask you to:
- Respect CGL and use tabs and not space for indenting
- Recreate your patch for current trunk (I just fixed the compatibility with DirectMail 2.7.0)
- Change your test for the uniqueness because it will only work if the users upgrade their direct_mail_userfunc configuration in Extension Manager, if not, it won't use the array_unique function anymore and this will be a change of behavior:
Your code (multiple places):
if ($extConf['makeEntriesUnique']) {
to be changed to:
if ($extConf['makeEntriesUnique'] !== '0') {
Thanks
Updated by Xavier Perseguers over 1 year ago
- Target version set to 1.3.0
Updated by Xavier Perseguers 3 months ago
- Target version changed from 1.3.0 to 1.3.1
Sorry, forgot about this one and just released 1.3.0, will make sure I don't wait 2 years again for another version :)
Updated by Xavier Perseguers 3 months ago
- File 32776_v2.diff added
- Status changed from Accepted to Under Review
- Assignee set to Xavier Perseguers
Rewrote patch with latest repository status. Please review.