Bug #32781
closedtransparent backColor causes transparent flicks and black background
100%
Description
- It may creates wrong transparent areas. That is because of the imagealphablending setting, which should not be there.
- It creates black backgrounds, when using an image object inside the GIFBUILDER, because the core sets the t3lib_stdgraphic::imagecopyresized_fix property to true by default.
Attached is a patch which resolves those issues.
Before pushing it to Gerrit, I'd like to know if the approach of fixing the second issue is correct, or should be done differently.
With this approach, the imagecopyresized_fix is overruled by the saveAlphaLayer property inside the t3lib_stdgraphic::imagecopyresized method. Since this approach is kind of obsolete, I see no problem with it. Backwards compatibility is is given, simply because upraded installations will have the saveAlphaLayer property set to false anyway.
Target Version: 4.6 and 4.7
Files
Updated by Georg Großberger over 12 years ago
- File transparent-backColor-fixes.diff transparent-backColor-fixes.diff added
- Target version set to 4.6.4
Wrong diff, here is the correct one:
The previous one shows another possible fix of the black background issue, but is not tested so well yet.
Updated by Philipp Gampe over 12 years ago
Would you mind pushing your patch to gerrit?
http://forge.typo3.org/projects/team-forge/wiki/Working_with_Git_and_Gerrit
Would you mind giving us a test setup (typoscript, maybe image) to reproduce the issue (and test the fix). Or describe how to reproduce with the introduction package.
Updated by Georg Großberger over 12 years ago
- File demo.tar.gz demo.tar.gz added
In the attachment, there is a txt file with a TS setup, and a simple PNG file used as background. I did a page.5 < lib.test.png to put it on display.
Gerrit push is on the way
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7622
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070
Updated by Anonymous about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 511ebd2be8a8ef31b65674c4a427f164fd349158.
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070
Updated by Gerrit Code Review almost 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070
Updated by Georg Großberger over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset 6dac2bc4a2cac687878f6cbd89fb097ffbc6f2b5.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13895
Updated by Georg Großberger over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset ebd4ff243bfc81d1ed5ea34e2d8a87b5026dde0f.