Bug #33148

CLDR locale chaining doesn't work correctly

Added by Adrian Föder over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2012-01-12
Priority:Must have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:I18n
Target version:TYPO3 Flow Base Distribution - 1.1
PHP Version: Complexity:medium
Has patch:No FLOW3 version affected:Git master
Votes: 0

Description

Simply said, the chaining in order to get also de.xml when de_DE.xml is asked for, doesn't work correctly.

The problem is mostly that the CldrRepository's findLocaleChain() that is responsible for that functionality, relies on a function localizationService->getParentLocaleOf(); while this function asks a localeCollection that never seems being populated correctly.

I'll add a test that should describe it better; anyhow I don't know if the mocking is correct (show inline PHP comment)

Associated revisions

Revision b2e4f3e9
Added by Adrian Föder over 1 year ago

[BUGFIX] CLDR locale chaining doesn't work correctly

When collecting CLDR resource files, the required chaining
is corrected (i.e. de_DE.xml also requires de.xml to be
included).

Change-Id: Ib10360c9d9f19cf2fedf1f880ede8b249fa67809
Fixes: #33148
Releases: 1.1

History

#1
Updated by Adrian Föder over 1 year ago

Test is here: https://review.typo3.org/#change,7750
Please disregard the "Depends on"; just see the test.
https://review.typo3.org/#change,7761

#2
Updated by Karsten Dambekalns over 1 year ago

  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns

#3
Updated by Karsten Dambekalns over 1 year ago

The use of getParentLocaleOf() in the CldrRepository is wrong - as it only contains Locales for which resources actually exist. For CLDR data the case is different, the handling needs to be adjusted.

#4
Updated by Karsten Dambekalns over 1 year ago

  • Subject changed from Locale Chaining doesn't work correctly to CLDR locale chaining doesn't work correctly

#5
Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7761

#6
Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7761

#7
Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7761

#8
Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7761

#9
Updated by Adrian Föder over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF