Feature #33518
closed
Allow authentication with partial OpenID identifier
100%
Description
Currently OpenID authentication requires the user to enter her full OpenID identifier (except for the last "/" which may be omitted):
http://<username>.<some-provider>.<tld>
or
https://<username>.<some-provider>.<tld>
This patch allows the user to enter only the useful part of this full identifier, namely:
<username>.<some-provider>.<tld>
Files
Updated by Xavier Perseguers about 12 years ago
- File 33518.diff 33518.diff added
- Status changed from New to Needs Feedback
Please find a patch for that. I'd like the security team and Dmitry to have a look at it before hopefully pushing to Gerrit.
Updated by Dmitry Dulepov about 12 years ago
Writing from iPad, so I did not look into diff. The idea is good but there is one issue. If the identifier contains a path, slash should not be appended. Urls with a slash and without it are different according to rfc. Java urls typically do not have a slash in the end, so appending the slash would break authentication. If that's not the case for the patch, the change should be good.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8764
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8764
Updated by Gerrit Code Review about 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8764
Updated by Gerrit Code Review about 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8764
Updated by Xavier Perseguers about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 19ea7938331bc198848eef8740170f6318ab028c.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9230
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9231
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9238
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9231
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9238
Updated by Gerrit Code Review about 12 years ago
Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9238
Updated by Gerrit Code Review about 12 years ago
Patch set 4 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9238
Updated by Wouter Wolters almost 12 years ago
Can be closed. Merged in 4.7.0beta1
Xavier Perseguers May 21
Patch Set 4: Abandoned
No more backports!
Updated by Ernesto Baschny almost 12 years ago
- Status changed from Under Review to Closed
Updated by Ernesto Baschny almost 12 years ago
- TYPO3 Version changed from 4.6 to 4.7