Bug #33546

Copy in pagetree without permission leads to faulty behavior of pagetree

Added by Andreas Bigger over 1 year ago. Updated 8 months ago.

Status:Resolved Start date:2012-01-31
Priority:Must have Due date:
Assignee:- % Done:

100%

Category:Pagetree
Target version:-
TYPO3 Version:4.5 Complexity:
PHP Version:
Votes: 0

Description

A redactor copies a page in pagetree via context-menu.

He inserts the same via context-menu into a page where he has no rights to insert it. Now, the following happens:
1. The menu for inserting the page is shown, even if the permissions are not there.
2. After the insertion you can read for a few seconds the following message:

Exception
[1.1.12]: Attempt to insert a record on page '%s' (%s) from table '%s' without permissions. Or non-existing page.

3. The page is inserted into the pagetree at the place selected as if the permissions were correct, but the page has the id of the original page. Any changes in this page affect the original.
4. After logout and relogin the copied page is no longer in the pagetree. Only the (changed) original is available.

Associated revisions

Revision ae2bbd14
Added by Max Roesch about 1 year ago

[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: Ief80a511d61ba386d667c62263d6f5335d1c87b8
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10483
Reviewed-by: Kilian Hann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Revision 0f340e3d
Added by Max Roesch 11 months ago

[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: Ief80a511d61ba386d667c62263d6f5335d1c87b8
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10483
Reviewed-by: Kilian Hann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Revision 351a23c6
Added by Max Roesch 11 months ago

[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: I91990bef4d34c840aa0a21e578250365f353a3ac
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11065
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Revision eb215bac
Added by Max Roesch 11 months ago

[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: I24b61c37ae76a4411ddb0b35feed46ab1f02f486
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11067
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Revision cdee4ff9
Added by Max Roesch 11 months ago

[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: I7823b96895f9e73c02894a1db893c0e48a36c938
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11066
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

History

Updated by Max Roesch about 1 year ago

I can confirm this behavior in TYPO3 4.6.7

Will have a look at it.

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10483

Updated by Andreas Bigger about 1 year ago

Tested it in our TYPO3 4.5.15 => works (inserting no longer possible)!

Copy with adequate permission works too.

Is there any other thing one should test?

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10483

Updated by Max Roesch about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11065

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11066

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11067

Updated by Max Roesch 11 months ago

  • Status changed from Under Review to Resolved

Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13176

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13302

Updated by Stefan Galinski 8 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF