Bug #33625
insufficient handling of $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] in class.t3lib_tcemain.php
| Status: | Resolved | Start date: | 2012-02-02 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | 4.5.12 | |||
| TYPO3 Version: | 4.5 | Complexity: | ||
| PHP Version: | 5.3 | |||
| Votes: | 1 (View) |
Description
Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE won't disable versioning because of insufficient handling in class.t3lib_tcemain.php
All occurrences of
if (isset($GLOBALS['TCA'][$table]['ctrl']['versioningWS'])) {}
should be changed to
if (isset($GLOBALS['TCA'][$table]['ctrl']['versioningWS']) && $GLOBALS['TCA'][$table]['ctrl']['versioningWS']) {}
Associated revisions
[BUGFIX] Properly check disabled versioning within tcemain
Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE; isn't
fully working within tcemain because some isset() checks don't
look at the value atm.
Change-Id: I5cfca5fa73a7f30b56342052ef0193f21999bce1
Fixes: #33625
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8836
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
[BUGFIX] Properly check disabled versioning within tcemain
Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE; isn't
fully working within tcemain because some isset() checks don't
look at the value atm.
Change-Id: I5cfca5fa73a7f30b56342052ef0193f21999bce1
Fixes: #33625
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9610
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
[BUGFIX] Properly check disabled versioning within tcemain
Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE; isn't
fully working within tcemain because some isset() checks don't
look at the value atm.
Change-Id: I75a994c5eb09c4cc5b4c68e986f42b4592fd1043
Fixes: #33625
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12834
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Marcus Schwemer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
[BUGFIX] Properly check disabled versioning within tcemain
Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE; isn't
fully working within tcemain because some isset() checks don't
look at the value atm.
Change-Id: I736e37ed04ef44ec26b7ab7ef7d2124656a73c0f
Fixes: #33625
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12833
Reviewed-by: Marcus Schwemer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8836
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9610
Updated by Tolleiv Nietsch over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6f3b746d239f2659a2bd5809ff17b96d318ea5fb.