Bug #33853

Selection lost after leaving filtering-mode

Added by Stefan Neufeind over 1 year ago. Updated 6 months ago.

Status:Resolved Start date:2012-02-11
Priority:Should have Due date:
Assignee:Jigal van Hemert % Done:

100%
Category:Pagetree
Target version:-
TYPO3 Version:4.5 Complexity:nightmare
PHP Version:
Votes: 1 (View)

Description

Reproduce:
  • Use filter to find some pages
  • Click on a page to select it
  • Close filter

In the right frame that page is still open. However the pagetree knows nothing about a selected index.

This behaviour is annoying for example in case you found a page and now need to close the filter to look after other pages on the same level. That would mean searching in the tree for the correct path, expand it.

Related issues

related to Core - Bug #25006: Backend search for page ID (uid) doesn't expand pagetree ... Resolved 2011-02-11

Associated revisions

Revision 582905ba
Added by Stefan Galinski about 1 year ago

[BUGFIX] Pagetree should expand to the last selected node

The patch integrates the expansion to the last selected node
at least for the following functions:
- selected node of the filtering tree
- OpenDocs
- Shortcuts (if possible)
- Live Search

Fixes: #25006
Fixes: #33853
Releases: 6.0, 4.7, 4.6, 4.5

Change-Id: I1a47bedd10a37a8931ccd50c7fd119399834d909
Reviewed-on: http://review.typo3.org/10357
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Marcus Schwemer
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski

Revision 63fd246e
Added by Stefan Galinski about 1 year ago

[BUGFIX] Pagetree should expand to the last selected node

The patch integrates the expansion to the last selected node
at least for the following functions:
- selected node of the filtering tree
- OpenDocs
- Shortcuts (if possible)
- Live Search

Change-Id: Ibe9ea4c826b6c59f72eab4945cf5cb4d30e306d3
Fixes: #25006
Fixes: #33853
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10376
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

History

#1
Updated by Stefan Neufeind over 1 year ago

One possible starting-point for investigation:
t3lib/js/extjs/components/pagetree/javascript/tree.js

#2
Updated by Thorsten Kahler over 1 year ago

  • Status changed from New to Accepted
  • Complexity set to medium

#3
Updated by Jigal van Hemert about 1 year ago

  • Assignee set to Jigal van Hemert

#4
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10357

#5
Updated by Stefan Galinski about 1 year ago

  • Complexity changed from medium to nightmare

#6
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10376

#7
Updated by Stefan Galinski about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8
Updated by Ingo Renner about 1 year ago

to which branches has this been applied? Has it been applied down to 4.5?

#9
Updated by Stefan Galinski about 1 year ago

Currently it's merged for master and pushed to Gerrit for 4.7, but Steffen must decide if it should be integrated for the final release (or the next RC). The patch needs changes for 4.6 and 4.5 if the virtual tree root feature from 4.7 isn't backported. Same for the rootline shortening patch from Joey for 4.5, but this is already in Gerrit. Reviews are welcome!

#10
Updated by Stefan Galinski about 1 year ago

  • Status changed from Resolved to Under Review

#11
Updated by Stefan Galinski about 1 year ago

  • Status changed from Under Review to Resolved

#12
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11048

#13
Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11048

#14
Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13132

#15
Updated by Stefan Neufeind 6 months ago

please mark as "resolved". patch for 4.5/4.6 abandoned, all others merged.

patch can't really be backported. needs total rework for 4.5/4.6. no time for that.

#16
Updated by Stefan Galinski 6 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF