Feature #33854

CurrencyViewhelper should get an attribute for prepending the currency sign

Added by Matthias Nitsch over 1 year ago. Updated 5 months ago.

Status:Resolved Start date:2012-02-11
Priority:Must have Due date:2012-02-11
Assignee:- % Done:

100%
Category:Fluid: ViewHelpers
Target version:- Estimated time:0.25 hour
Complexity:
Votes: 0

Description

Because of the fact that especially the dollar sign is prepended the value the ViewHelper shoul get an attribute to set this if needed.

I'll submit a patch shortly.

betterCurrencyViewHelper.patch (1.8 kB) Matthias Nitsch, 2012-02-11 13:47

Related issues

related to TYPO3.Fluid - Feature #36014: Prepend currency sign Resolved

History

#1
Updated by Matthias Nitsch over 1 year ago

I changed the viewhelper so that it can deal with the prepend append problem and added it as a patch. Sadly I was not able to push directly to Gerrit.

#2
Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10444

#3
Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10444

#4
Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10444

#5
Updated by Ingo Pfennigstorf about 1 year ago

There also has to be a configuration for whether having a space between currency symbol or not. This viewhelper always inserts one.

#6
Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10444

#7
Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10444

#8
Updated by Ingo Pfennigstorf 10 months ago

  • Status changed from Under Review to Resolved

Merged

#9
Updated by Gerrit Code Review 6 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch fluid_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16352

#10
Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch fluid_1-4 has been pushed to the review server.
It is available at http://review.typo3.org/16353

#11
Updated by Ingo Pfennigstorf 6 months ago

  • Status changed from Under Review to Resolved

#12
Updated by Anja Leichsenring 5 months ago

  • Project changed from Extbase MVC Framework to Fluid
  • Category changed from 963 to Fluid: ViewHelpers

Also available in: Atom PDF