Feature #34080
tt-news-indexer: Add tags of SysFolder
| Status: | Resolved | Start date: | 2012-02-18 | |
|---|---|---|---|---|
| Priority: | Could have | Due date: | ||
| Assignee: | Stefan Froemken | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| Votes: | 0 |
Description
The tt-news-indexer should optionally add tags of the SysFolder, if the SysFolder is located in a sub-tree for which a filter-option assignes a tag recursively.
Example:
Page-Tree:
root
-sub1
--SysFolder1
---news11
---news12
-sub2
--SysFolder2
---news21
---news22
Filteroptions:
Filter-Option1: "Tag subtree sub1 with tag1"
Filter-Option2: "Tag subtree sub2 with tag2"
This setup would allow the user to search the news based on the selection of the tags associated with the sub-trees. The BE-Users don't have to tag each news manually.
I've sent Magnus a patch some weeks ago.
Associated revisions
updated version of templavoila indexer
integrated patch for forge issue #34080
updated version of templavoila indexer
integrated patch for forge issue #34080
History
Updated by Christian Buelter about 1 year ago
- Status changed from New to On Hold
- Priority changed from Should have to Could have
We're working on a feature where tt_news-categories are connected with ke_search-tags.
So if you set a category, the indexer assigns a tag automatically.
I think this is more useful since using categories is the natural way to organize news in TYPO3.
Updated by Jan Bartels about 1 year ago
- File screenshot_issue_34080.png added
See cumulative patch at #34495
It might still be useful to assign the tt_news search-categories from the pages/sysfolders where the news are stored. At our site the tt_news-categories and the search-categories differ from each other. Consider this feature as a more general prototype that can be used with custom extensions/database-tables, too, even if they don't use any categories. This approach can easily be adapted to many custom indexers leading to a consistent category handling for the user.
I've implemented this feature to be optional. Just check this option to be active in the tt-news-indexer-configuration if you want or leave it in its default state (i.e. inactive). See attached screen shot.
Updated by Jan Bartels about 1 year ago
- File Patch_34080.patch added
I've prepared a patch for this feature-request. The main idea is to move the functions getPagelist(), getPageRecords() and addTagsToPageRecords() of the class tx_kesearch_indexer_types_page to the base-class tx_kesearch_indexer_types, where they can be called from the class tx_kesearch_indexer_types_ttnews or tx_kesearch_indexer_types_tt_address (similar approach as in #34077). The indexers build a page-list containing the page-tags if the option is selected in the indexer-configuration. Later on, they use the page-tags to initialize the tag-list of the index-record. The patch doesn't contain indexers other than for the pages, tt_news and tt_address, as I can't test other indexers. This concept can be applied to other indexers as well (e.g. ke_yac (?) or custom indexers).
Updated by Stefan Froemken about 1 year ago
- Status changed from On Hold to Resolved
- Assignee set to Stefan Froemken
- % Done changed from 0 to 100
I have committed your patch to SVN
Updated by Jan Bartels 12 months ago
- File patch_34080_rev_62740.patch added
- Status changed from Resolved to New
The tags aren't set if the records are stored in a SysFolder. The current trunk differs from my suggested patch in some issues. See attached patch "patch 34080 rev 62740.patch" for a correction. This might be a problem that arose from the conflicting integration of my various other patches (especially for #34077).
Updated by Stefan Froemken 12 months ago
Hello Jan,
you're right. There are some differences between the various patches. I have executed your patch and committed the new version for testing.
Stefan
Updated by Christian Buelter 12 months ago
- Status changed from New to Needs Feedback
Hello Jan,
would you test the current trunk version if it works as expected?
Please note that your patch does not work recursively as you described it!
Updated by Jan Bartels 12 months ago
Works as expected.
How is the recursive scenario you mentioned?
As I wrote in the original description our setup is as follows:
Page-Tree: root -sub1 --SysFolder1 ---news11 (news-record) ---news12 (news-record) -sub2 --SysFolder2 ---news21 (news-record) ---news22 (news-record)
Filteroptions:
Filter-Option1: "Tag subtree sub1 with tag1"
Filter-Option2: "Tag subtree sub2 with tag2"
Now all news-Records stored in SysFolder1 (i. e. news-records news11 and news12) are tagged with "tag1" and all news-Records stored in SysFolder2 (i. e. news-records news21 and news22) are tagged with "tag2". This is what I call "recursive". Do you have another definition of "recursive"?
Updated by Christian Buelter 12 months ago
- Status changed from Needs Feedback to Resolved
OK, then everything is fine.
I thought "sub1" and "sub2" in your chart should also be sysfolders which inherit their tags to the sysfolders "SysFolder1" and "SysFolder2".
But now I understand.
I close this issue then.