Bug #34116

setNewIndex() breaks when invalid position is given

Added by Karsten Dambekalns over 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:2012-02-20
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%

Category:Node handling
Target version:-
Votes: 0

Description

When an invalid position is given to setNewIndex(), the index of the target node iss either set to NULL or the code will break due to the use of an uninitialized variable.

Associated revisions

Revision fd662bdd
Added by Karsten Dambekalns about 1 year ago

[BUGFIX] Make setNewIndex() throw exception on invalid position

When an invalid position was given to setNewIndex(), the index of
the target node was either set to NULL or the code would break due
to the use of an uninitialized variable.

This change makes the method throw an InvalidArgumentException in
case an invalid position is given.

Change-Id: Id35d0cf17f117441a1ac0444628ffa2e91784130
Fixes: #34116

History

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9126

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9126

Updated by Karsten Dambekalns about 1 year ago

  • Status changed from Accepted to Under Review

Updated by Aske Ertmann about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF