Bug #34473

Fatal error is thrown in xliff parser if a xlf file contains XML in wrong format

Added by Nico de Haen over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2012-03-02
Priority:Should have Due date:
Assignee:Jigal van Hemert % Done:

100%

Category:-
Target version:4.7.0-beta2
TYPO3 Version:4.7 Complexity:easy
PHP Version:
Votes: 0

Description

If there is no $root->file->body element, in the SimpleXmlObject, the method children() can't be called:
Fatal error: Call to a member function children() on a non-object in /Typo3/Sources/typo3_trunk/t3lib/l10n/parser/class.t3lib_l10n_parser_xliff.php on line 47

Associated revisions

Revision 1199739a
Added by Jigal van Hemert over 1 year ago

[BUGFIX] Fatal error if xlf file has wrong format

Check if there is a file->body element before trying to parse it
further.

Change-Id: I07c4f88199c7c8102ad5c02f19675a06f6c67b32
Fixes: #34473
Releases: 4.8, 4.7, 4.6
Reviewed-on: http://review.typo3.org/9530
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Revision df585627
Added by Jigal van Hemert over 1 year ago

[BUGFIX] Fatal error if xlf file has wrong format

Check if there is a file->body element before trying to parse it
further.

Change-Id: I07c4f88199c7c8102ad5c02f19675a06f6c67b32
Fixes: #34473
Releases: 4.8, 4.7, 4.6
Reviewed-on: http://review.typo3.org/9588
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Revision 7189c98f
Added by Jigal van Hemert over 1 year ago

[BUGFIX] Fatal error if xlf file has wrong format

Check if there is a file->body element before trying to parse it
further.

Change-Id: I07c4f88199c7c8102ad5c02f19675a06f6c67b32
Fixes: #34473
Releases: 4.8, 4.7, 4.6
Reviewed-on: http://review.typo3.org/9592
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

Updated by Jigal van Hemert over 1 year ago

  • Status changed from New to Accepted
  • Complexity set to easy

Updated by Steffen Ritter over 1 year ago

  • Target version set to 4.7.0-beta2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9530

Updated by Jigal van Hemert over 1 year ago

  • Assignee set to Jigal van Hemert

Updated by Jigal van Hemert over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9588

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9588

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9592

Updated by Jigal van Hemert over 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF