Bug #34581
closed
Methods should not be private
100%
Description
Class tx_linkvalidator_Processor contains 2 private methods. This should be avoided at all costs, since it prevents useful XCLASSing. You would need very good reasons to make methods private. They should be protected instead. CGL reference: http://typo3.org/documentation/document-library/core-documentation/doc_core_cgl/4.5.1/view/1/3/
Was there a real reason for this decision or can it be changed?
Updated by Philipp Gampe about 12 years ago
I guess there was no reason. I will change it.
Updated by Chris topher about 12 years ago
These private methods were introduced in #12649. The task was about splitting one method into several smaller methods, because the nesting would have been too deep otherwise. I can't remember there was a reason to make them private.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9641
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9744
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9746
Updated by Anonymous about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:4626d810d28c76d4c401fb489df07b4de614e0c7.
Updated by Michael Stucki over 10 years ago
- Project changed from 1510 to TYPO3 Core
- Category changed from Linkvalidator to Linkvalidator
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed