Task #34771

Add missing sql_free_result in alt_doc.php

Added by Wouter Wolters over 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:2012-03-12
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:-
Target version:-
TYPO3 Version:4.5 Complexity:
PHP Version:5.3
Votes: 0

Description

In the file alt_doc.php there is the function editRegularContentFromId.
This function does not properly free the resource.

if ($GLOBALS['TYPO3_DB']->sql_num_rows($res))    {
    $ecUids=array();
    while($ecRec = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res))    {
        $ecUids[]=$ecRec['uid'];
    }
    $this->editconf['tt_content'][implode(',',$ecUids)]='edit';
}

If accepted I can provide a patch for it:)

Associated revisions

Revision d0a5a7f8
Added by Wouter Wolters over 1 year ago

[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: If2a6f291bd8839d1b7a2a617a192fe1d175f7cde
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9757
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Revision 2982e4fc
Added by Wouter Wolters about 1 year ago

[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: Ic36b13edcbb10e6687df5cf85078375fa4f1c377
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9867
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 0c5402a0
Added by Wouter Wolters about 1 year ago

[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: Ic6317ddc7810daf987c3801c13f4f968c4d317e9
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9866
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision ddad96bf
Added by Wouter Wolters about 1 year ago

[TASK] Add missing sql_free_result in alt_doc.php

Add missing sql_free_result in alt_doc.php to free hanging
records properly.

Change-Id: I5c43aef985f85507301fe62400d5c9b612ce57d2
Resolves: #34771
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9865
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1
Updated by Oliver Hader over 1 year ago

  • Status changed from New to Accepted
  • PHP Version set to 5.3

Go ahead :)
Fixing hanging record sets is always good...

#2
Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9757

#3
Updated by Wouter Wolters over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9865

#5
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9866

#6
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9867

#7
Updated by Wouter Wolters about 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF