Bug #35016

YamlSource creates invalid YAML files

Added by Bastian Waidelich over 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:2012-03-19
Priority:Should have Due date:
Assignee:Bastian Waidelich % Done:

100%
Category:Configuration
Target version:TYPO3 Flow Base Distribution - 1.1
PHP Version: Complexity:no-brainer
Has patch:No FLOW3 version affected:Git master
Votes: 0

Description

\TYPO3\FLOW3\Tests\Unit\Configuration\Source\YamlSource::save() currently separates the header from the configuration with PHP_EOL but it should be chr(10) according to the guidelines.
Apart from that, generated YAML files are not indented correctly, making it difficult to read them

Associated revisions

Revision 36e46e74
Added by Bastian Waidelich over 1 year ago

[BUGFIX] YamlSource creates invalid YAML files

YamlSource::save() currently creates Windows style EOLs
and indentation is lost in YAML files.

Change-Id: Ibc9da029e69ec52aab2dd9955dbde3afbbd6f837
Fixes: #35016
Releases: 1.1

History

#1
Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9748

#2
Updated by Sebastian Kurfuerst about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF