Bug #35035

Doctrine repository findAll is inconsistent

Added by Christopher Hlubek about 1 year ago. Updated 10 months ago.

Status:Resolved Start date:2012-03-20
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:Persistence
Target version:TYPO3 Flow Base Distribution - 1.1 RC2
PHP Version: Complexity:
Has patch:No FLOW3 version affected:FLOW3 1.0.0
Votes: 0

Description

The findAll method of the special doctrine repository (needed for custom DQL afaik) returns an array of objects (through parent::findAll). The default repository does return a QueryResult object which is needed for widgets etc. to work. Also the Doctrine Query itself does return a QueryResult in execute(). So the current behavior is inconsistent and can lead to bugs.

Related issues

related to TYPO3.Flow - Bug #38381: Doctrine Repository | findAll()-method does not consider ... Resolved 2012-06-25
related to TYPO3.Flow - Bug #38841: Magic findBy methods in Doctrine\Repository do not return... Resolved 2012-07-10

Associated revisions

Revision 93658121
Added by Karsten Dambekalns 10 months ago

[BUGFIX] Have Doctrine\Repository::findAll() return a QueryResult

This makes the behavior of Doctrine\Repository consistent and
allows the use of findAll() e.g. in combination with widgets.

With this change, findAll() also observes the default ordering
of a repository.

Change-Id: If24afae617a745d791d5fc81ab070e5d3738a545
Fixes: #35035
Fixes: #38381
Releases: 1.1, 1.2

History

#1
Updated by Karsten Dambekalns about 1 year ago

  • Status changed from New to Accepted
  • Target version set to 1.1

#2
Updated by Karsten Dambekalns 12 months ago

  • Target version changed from 1.1 to 1.1 RC1

#3
Updated by Karsten Dambekalns 11 months ago

  • FLOW3 version affected changed from Git master to FLOW3 1.0.0

#4
Updated by Gerrit Code Review 11 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12365

#5
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12365

#6
Updated by Karsten Dambekalns 11 months ago

  • Target version changed from 1.1 RC1 to 1.1

#7
Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12365

#8
Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12365

#9
Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12873

#10
Updated by Karsten Dambekalns 10 months ago

  • Status changed from Under Review to Resolved
  • Target version changed from 1.1 to 1.1 RC2
  • % Done changed from 0 to 100

Also available in: Atom PDF