Bug #35041

TranslateViewHelper returns empty string if id is missing and view helper tag is empty

Added by Andreas Wolf about 1 year ago. Updated 12 months ago.

Status:Resolved Start date:2012-03-20
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:ViewHelpers
Target version:TYPO3 Flow Base Distribution - 1.1 beta 2
Has patch:No FLOW3 version affected:Git master
Votes: 0

Description

With an empty view helper tag (<f:translate id="some.message.id" />) and a missing id, the view helper just returns nothing instead of displaying the id. From what is specified for the i18n API, I would expect to get the ID.

35041.diff (628 Bytes) Andreas Wolf, 2012-03-20 15:23

Associated revisions

Revision cd86a2dd
Added by Karsten Dambekalns 12 months ago

[BUGFIX] Avoid empty output of TranslateViewHelper

If translation by ID is used but no translation is found, the ID will now be
returned if the view helper tag has no content. Before this change it would
just return nothing (printable, at least).

Change-Id: I8c0331e60c8ecc08eb2323f6cc3c54d178b90f0c
Fixes: #35041
Releases: 1.1, 1.2

Revision 68e3bad5
Added by Karsten Dambekalns 12 months ago

[BUGFIX] Avoid empty output of TranslateViewHelper

If translation by ID is used but no translation is found, the ID will now be
returned if the view helper tag has no content. Before this change it would
just return nothing (printable, at least).

Change-Id: I8c0331e60c8ecc08eb2323f6cc3c54d178b90f0c
Fixes: #35041
Releases: 1.1, 1.2

History

#1
Updated by Andreas Wolf about 1 year ago

#2
Updated by Karsten Dambekalns about 1 year ago

  • Category set to ViewHelpers
  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns

#3
Updated by Gerrit Code Review 12 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11613

#4
Updated by Karsten Dambekalns 12 months ago

  • Target version set to 1.1 beta 2

#5
Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11613

#6
Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11627

#7
Updated by Karsten Dambekalns 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF