Workspaces & Versioning

Bug #35172

Connection timeout when parsing large number of changed records

Added by Michal Krypczyk about 1 year ago. Updated 4 months ago.

Status:

Resolved

Start date:

2012-03-23

Priority:

Must have

Due date:

Assignee:

% Done:

100%

Category:

Bugs

Target version:

TYPO3 Version:

4.5

PHP Version:

5.3

Votes:

10 (View)

Description

Connection timeout occurs when large number of modified records is being loaded in Workspaces module.

AJAX timeout (after 30 secods) seems to be the cause.

Some more details:
- workspace (live/draft) doesn't matter
- multiple domains in TYPO3 installation

Alosi the Depth selection is reset to Infinite when another page in pagetree is selected.

Related issues

related to Workspaces & Versioning - Bug #30405: Switching Workspaces results in Connection Timeout	Closed	2011-09-28
related to Workspaces & Versioning - Bug #39731: Calculate percentage of differences if column is shown	Under Review	2012-08-12
related to Workspaces & Versioning - Bug #39727: Calculating percentage of differences is slow	Rejected	2012-08-12
related to Workspaces & Versioning - Task #44189: Workspaces: Preview all for editors	Accepted	2012-12-21

Associated revisions

Revision 4141276e
Added by Ingo Pfennigstorf 10 months ago

[BUGFIX] Prevent time-outs when calculating change percentage

Fixes the complex and unnecessary calculation of the change percentage
of a record. This may have led to various timeouts when calculating this
for long strings.

Change-Id: I726236a37b0cf71772befeeabb3f0f18fe86a037
Fixes: #35172
Releases: 6.0
Reviewed-on: http://review.typo3.org/10949
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 39e65d11
Added by Ingo Pfennigstorf 4 months ago

[BUGFIX] Prevent time-outs when calculating change percentage

Fixes the complex and unnecessary calculation of the change percentage
of a record. This may have led to various timeouts when calculating this
for long strings.

Since this is still a nasty issue in older branches too, the
patch that was already released to 6.0 is now backported
to 4.7, 4.6, 4.5

Change-Id: I726236a37b0cf71772befeeabb3f0f18fe86a037
Fixes: #35172
Releases: 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17932
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision a592c534
Added by Ingo Pfennigstorf 4 months ago

[BUGFIX] Prevent time-outs when calculating change percentage

Fixes the complex and unnecessary calculation of the change percentage
of a record. This may have led to various timeouts when calculating this
for long strings.

Since this is still a nasty issue in older branches too, the
patch that was already released to 6.0 is now backported
to 4.7, 4.6, 4.5

Change-Id: I726236a37b0cf71772befeeabb3f0f18fe86a037
Fixes: #35172
Releases: 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17931
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 06034536
Added by Ingo Pfennigstorf 4 months ago

[BUGFIX] Prevent time-outs when calculating change percentage

Fixes the complex and unnecessary calculation of the change percentage
of a record. This may have led to various timeouts when calculating this
for long strings.

Since this is still a nasty issue in older branches too, the
patch that was already released to 6.0 is now backported
to 4.7, 4.6, 4.5

Change-Id: I726236a37b0cf71772befeeabb3f0f18fe86a037
Fixes: #35172
Releases: 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17616
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1
Updated by Jigal van Hemert about 1 year ago

Found the cause: Tx_Workspaces_Service_GridData::calculateChangePercentage() uses similar_text() to calculate the degree of difference between the content. This function is very slow for longer strings (complexity O(N**3); N is length of longest string). For some records the time needed to calculate the change percentage took several seconds. With a few hundred records in a workspace list it would easily cause a time-out.
Limiting the strings to maximum 512 chars solves the time-outs, at least until a faster function is found.

#2
Updated by Ingo Pfennigstorf about 1 year ago

@Jigal That should not be hard to implement. Is there any use case where displaying the percentage really matters that much, that the string length cannot be cropped?

Does it work for you with a limitation to 512 chars?

#3
Updated by Ingo Pfennigstorf about 1 year ago

So, why is this calculation still in workspaces?
With #11585 the display of the percentage was dropped (also see http://lists.typo3.org/pipermail/typo3-team-workspace/2011-January/000184.html
So I think that this calculation is obsolete and I'm going to write a patch for this, or did I miss something?