Bug #35202
Fix the unit tests to work with PHPUnit 3.6
| Status: | Resolved | Start date: | 2012-03-23 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Oliver Klee | % Done: | 100% |
|
| Category: | Unit Tests | |||
| Target version: | - | |||
| TYPO3 Version: | 4.7 | Complexity: | ||
| PHP Version: | 5.3 | |||
| Votes: | 0 |
Description
The current trunk of the phpunit extension brings PHPUnit 3.6. Let's fix the unit tests to work with this version.
Related issues
| related to Core - Bug #35905: Failing test in autoloader with phpunit 3.6 | Resolved | 2012-04-12 |
Associated revisions
[BUGFIX] Fix the unit tests to work with PHPUnit 3.6
Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.
Change-Id: I2197b88fae4e90d8c5ceaa0f983f43ef1388ed02
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10187
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Fix the unit tests to work with PHPUnit 3.6
Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.
Change-Id: I0157618b0d7c87f6c4c1a47076516ea4cfeb7d0c
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10350
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Fix the unit tests to work with PHPUnit 3.6
Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.
Change-Id: I103bb4ab8026613bbc20537a14ae027b5aeff47d
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10351
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Fix the unit tests to work with PHPUnit 3.6
Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.
Change-Id: I286ae33bfaffec3e347fbb1a67910aeb3afa623e
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10352
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
Updated by Oliver Klee about 1 year ago
This also includes changing all "throw new Exception" to use a subclass because otherwise this cannot be unit-tested (PHPUnit 3.6 does not allow checking for the Exception base class.)
Updated by Oliver Klee about 1 year ago
Note: The patch for this bug will only include fixes for the issues that seems to be related to the differences between PHPUnit 3.5 and PHPUnit 3.6. The patch is not about fixing real bugs in the code.
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10187
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10187
Updated by Christian Kuhn about 1 year ago
#35905 already fixed the autoloader tests.
Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10187
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10350
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10351
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10352
Updated by Oliver Klee about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 89232cdbe21fdf813702a5a22fa14fa7fe68029e.