Bug #35261
Pagebrowser and highlighting of current page
| Status: | Resolved | Start date: | 2012-03-27 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | Frontend | |||
| Target version: | 2.1.0 | Estimated time: | 0.25 hour | |
| TYPO3 Version: | 4.5 | Has patch: | No | |
| PHP Version: | 5.2 | Complexity: | easy | |
| Votes: | 1 (View) |
Description
If list.paginate.forcedNumberOfLinks is greater than list.paginate.pagesBefore then the "current" class is not written to the actual element in the pagebrowser.
This happens form the moment on when there are few or equal than forcedNumberOfLinks pages shown in the pagebrowser.
Workaround: set forcedNumberOfLinks to <= pagesBefore via typoscript.
Associated revisions
[TASK] Improve Pagination + Unittests
Resolves: #35261
Change-Id: Idd6e4e4a9dd28e6607c76f33e991cb6452c8ff19
Reviewed-on: https://review.typo3.org/18399
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
Updated by Frank Gerards about 1 year ago
noticed that also,
workaround doesnt work, if your layout/customer demands forcedNumberOfLinks => pagesBefore :).
Updated by Georg Ringer about 1 year ago
hey guys,
thanks for reporting. do you wanna come up with a patch as it seems that you got already the use cases and I don't, would be great!
Updated by Joe Kolade about 1 year ago
Georg Ringer wrote:
do you wanna come up with a patch as it seems that you got already the use cases and I don't, would be great!
I tried to put some time in this, but I didn't make it.
I'll try to fix it as soon as I've got some time... since noone else fixed until then.
Updated by Martin Eberle 5 months ago
- File PaginateController.php added
i had the same problem and fixed it:
Updated by Georg Ringer 5 months ago
wanna add a diff file? would make it easier to see what you changed. thx
Updated by Gerrit Code Review 4 months ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18399
Updated by Georg Ringer 4 months ago
- Status changed from Under Review to Resolved
- Target version set to 2.1.0