Bug #35765

SXW Manual download has HTML appended

Added by Christian Zenker about 1 year ago. Updated 12 months ago.

Status:Resolved Start date:2012-04-07
Priority:Should have Due date:
Assignee:- % Done:

90%
Category:[FOR] TER
Target version:Public Beta
Votes: 0

Description

http://typo3.org/extension-manuals/tt_news/3.2.0/sxw/?no_cache=1

This leads to OOo complaining about a broken file and some browsers recognizing an HTML file instead of a binary.

History

#1
Updated by Joern Bock about 1 year ago

  • Target version set to Public Beta

#2
Updated by Thomas Loeffler about 1 year ago

  • Status changed from New to Needs Feedback

The link leads to a manual.sxw file.
What is the problem in detail, Christian?

By the way, my OO says that this file is broken. After repairing it, it works.

#3
Updated by Christian Zenker about 1 year ago

  • Subject changed from name of SXW Manual download defaults to manual.html in TER to SXW Manual download has HTML appended

Thomas Loeffler wrote:

The link leads to a manual.sxw file.

Interesting. I thought Content-Disposition was missing, but it is not. Defaulting the filename to manual.html seems only to happen in Opera, not Chrome or Firefox (although FF seems to accept the extension although it recognizes an HTML file)

What is the problem in detail, Christian? By the way, my OO says that this file is broken. After repairing it, it works.

Yes I think this is the main problem here: Have a look at the file with a hex editor. At the very end of the file you see that the HTML template of the website is appended. I think this causes all the strange behaviors.

#4
Updated by Thomas Loeffler about 1 year ago

Unfortunately I can't test it on my local machine because no manuals are generated.
In the ter_fe code there is a call for terdocapi to get the documentation link.

I would ask Fabien to look for it.

#5
Updated by Thomas Loeffler about 1 year ago

  • Status changed from Needs Feedback to Accepted

#6
Updated by Thomas Loeffler about 1 year ago

  • Assignee set to Thomas Loeffler

Yes, there is the typo3.org website appended after sxw file.
Seems there is no config.disableAllHeaderCode set.

#7
Updated by Thomas Loeffler about 1 year ago

  • Assignee changed from Thomas Loeffler to Tolleiv Nietsch

There is TypoScript missing on the extension manual page.

Tolleiv, can you put this TypoScript Snippet on page "Read online" (334) on latest to test it?

[globalVar = GP:tx_terdoc_pi1|format=ter_doc_sxw]
config.disableAllHeaderCode = 1
[global]

After that the manuals should be generated without errors and appended HTML.

#8
Updated by Thomas Loeffler about 1 year ago

  • Status changed from Accepted to Needs Feedback

There is no manual rendering on latest, so we cannot test it there.
Either the manual rendering is working on latest or the TypoScript should be inserted on typo3.org directly.

#9
Updated by Thomas Loeffler 12 months ago

  • Status changed from Needs Feedback to Under Review
  • Assignee deleted (Tolleiv Nietsch)
  • % Done changed from 0 to 90

Added typoscript condition and constant in typoscript files.
Must be tested on typo3.org.

#10
Updated by Thomas Loeffler 12 months ago

  • Status changed from Under Review to Resolved

Implemented and tested on typo3.org with Steffen.
Bugfix committed in ter_doc extension, rev 62878.

Also available in: Atom PDF