Feature #36237
constants for cssPath
| Status: | Resolved | Start date: | 2012-04-17 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Georg Ringer | % Done: | 100% |
|
| Category: | - | |||
| Target version: | 1.4.0 | |||
| TYPO3 Version: | 4.7 | Has patch: | No | |
| PHP Version: | Complexity: | |||
| Votes: | 0 |
Description
for easily moving a styled extensionlayout to another installation by only changing the constants ( no code(paths) in layouts must be changesd), it would be great if the following could be implemented:
1.) CONSTANTS- cat=plugin.tx_news/file; type=string; label=Path to template CSS (FE):
plugin.tx_news.view.cssPath = EXT:news/news/Resources/Public/Css/
2.) SETUP
plugin.tx_news.settings.cssPath = {$plugin.tx_news.view.cssPath}
3.) in LAYOUTS etc. somthing like:
<n:includeFile path="{settings.cssPath}news-basic.css" />
Associated revisions
[FEATURE] Constants/Setup for css file
use settings.cssFile to set css file via TS
Change-Id: I017b0cb398773861e59d2772a75893fe975e13c9
Resolves: #36237
History
Updated by Georg Ringer about 1 year ago
- Status changed from New to Accepted
wanna do a patch for that?
Updated by Ralf-Rene Schroeder about 1 year ago
i never have created a patch (i'm not a programmer, more an intergrator)...
i think if you use the three lines above it's much less risk, also for you
but with a little hints i will try my very best...
Updated by Georg Ringer about 1 year ago
- Assignee set to Georg Ringer
- Target version set to 1.4.0
you can read through http://wiki.typo3.org/Git but I will do this patch, thx for the idea!
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10641
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10641
Updated by Georg Ringer about 1 year ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Updated by Ralf-Rene Schroeder about 1 year ago
thanks for doing that patch...
but with a constant cssFile, this would not be optimal
in a layout can it be usefull to have more css files (or maybe there will also be more than one layout)
so my hint to use a cssPath constants seems to be more flexible (i hope you see it like me)
at least for MY projects i need this - ok, this could i do by myself, but i think also for others it will be a better solution
(the filenames are defined in the layout(s) - the PATH outside by typoscript ... by templates, partials you also do it like this)
Updated by Georg Ringer about 1 year ago
sorry I disagree. if you got multiple layouts and need different styles you need to change already everything and no default behaviour will help you there. with current status you can integrate one full file and if you remove it from TS, nothing is included and you can work with your own css files.
ext:news tries to give the users an easy way to configure things, not to show by default everything which is possible by fluid.