Bug #36537

Wrong author shown for Extensions

Added by Steffen Gebert about 1 year ago. Updated 10 months ago.

Status:Resolved Start date:2012-04-25
Priority:Must have Due date:
Assignee:- % Done:

100%

Category:[FOR] TER
Target version:Public Beta
Votes: 0

Description

Hi,

we got two requests that the authors shown in ter_fe are wrong:

  • netcreators Extensions are owned by Michiel Roos, who already left the company (old vs. new)
  • Julian Fries complained that his extension easytabs is now owned by someone called Detlef Fluess.

rebuild_author.php (4.2 kB) Thomas Loeffler, 2012-07-09 22:18

History

Updated by Steffen Gebert about 1 year ago

It seems like restdoc is another example. The owner should be still Xavier, but in the ext_emconf.php definitions look like this:

    'author' => 'Xavier Perseguers',
    'author_email' => 'xavier AT causal.ch',
    'author_company' => 'Causal Sàrl',

Updated by Xavier Perseguers about 1 year ago

Exactly. The interesting point is that I have another extension, namely EXT:egovapi, that has the same author_email and provides the name I see in front of EXT:restdoc: "Xavier Perseguers / SECO". Perhaps there is some cache between email address and corresponding name, that seems like the best guess so far.

Updated by Tolleiv Nietsch about 1 year ago

  • Status changed from New to Accepted

Thanks for the insights - I assume the [FOR] Ter team should work on this with highest priority.

Updated by Steffen Gebert about 1 year ago

Extension easytabs has no email set in ext_emconf.php, which somehow maps this to a different user (Detlev F.) instead of showing the value from ext_emconf.php (Julian F.)

Updated by Helmut Hummel about 1 year ago

  • % Done changed from 0 to 50

I committed a hotfix and applied the changes to the live system.

Now the single view of the extension shows the owner of the extension (like it was before).

The list still shows the author of the last version (which still may be wrong)

TODO:

  • Cleanup
  • List View
  • Check why author of version is wrong
  • decide whether to use the owner also as author for the versions

Updated by Kai Vogel about 1 year ago

It's not even better to show only the owner of an extension. The idea behind the solution was that the authors may vary per version. Someone can join the team or one other leaves. Therefore only the authors of the last version are really meaningful. And because the list shows only the last version of each extension it's absolutely correct to show only the authors of this last version there.

Updated by Thomas Loeffler 12 months ago

What is the status here?

Updated by Steffen Gebert 12 months ago

Yes, I would be very interested to!

Updated by Thomas Loeffler 12 months ago

Kai committed a bugfix to not search the author if no email is set.
Helmut committed on the wrong repository I think. :)
I think it's also in Ingo's mind to define what to show in list/search view.
We should define what to show in detail view.

What is more important for the user? To know who is the owner or the current maintainer of the extension?
I think the maintainer is more important.
On single view we can show the owner too, if it's a different person.
In the list view it's not important to show the possible owner.

So, who gives me a +1 for that solution? :)
I would do it as fast as possible.

Updated by Thomas Loeffler 11 months ago

  • % Done changed from 50 to 70

Old: Author is searched by email address. If there is a match the author record is set. If there is no match a new author is set.

New: If there is a match for the email address there is a check for the name. If the name of the author changed a new author record will be set.

Needs to be tested on latest.

Updated by Thomas Loeffler 11 months ago

  • Status changed from Accepted to Under Review

Updated by Thomas Loeffler 11 months ago

This commit is only for new uploaded extensions.

Updated by Thomas Loeffler 11 months ago

  • Status changed from Under Review to Accepted
  • Assignee set to Thomas Loeffler

All existing extension versions must be checked for wrong authors.

There is e.g. the case of an empty author email in the uploaded extension. All versions with an empty email are linked to Detlef Fluess:
http://typo3.org/search/?id=180&L=0&tx_solr[q]=detlef+fluess

Updated by Thomas Loeffler 11 months ago

Hi Tolliev,

based on our Skype today, here is my cleaning script for the authors.
You have to copy it into fileadmin.

Please test it on latest based on the search for "Detlef Fluess" in TER.

If you have questions, don't hesitate to skype me. :)

Updated by Tolleiv Nietsch 10 months ago

  • Status changed from Accepted to Needs Feedback
  • Assignee changed from Tolleiv Nietsch to Thomas Loeffler

Hi -the script runs ~60 minutes and does seem to work - but it does not trigger the Solr indexer. Therefore it won't have an effect on the list output. Can you talk to Ingo how to resolve this?

Updated by Thomas Loeffler 10 months ago

  • Status changed from Needs Feedback to Resolved
  • Assignee deleted (Thomas Loeffler)
  • % Done changed from 70 to 100

Fixed on typo3.org.

Also available in: Atom PDF