Bug #36592
TYPO3VersionTest ".latest" fails for RC versions
| Status: | New | Start date: | 2012-04-26 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Christian Weiske | % Done: | 0% |
|
| Category: | Tests/Operations | |||
| Target version: | - | |||
| Votes: | 1 (View) |
Description
A host has TYPO3 4.7.0rc1, yet the version test for "4.7.0" and "4.7.latest" succeeds.
This is because checkVersionRange in class.tx_caretakerinstance_RemoteTestServiceBase.php does a versionToInt() call, which does not care about RC versions at all.
Maybe caretaker_instance should use php's version_compare() method instead of building that one itself. php's comparision method has support for alpha, beta, RC etc.
Related issues
| related to Caretaker - Bug #32819: TYPO3 Versionnumbers Update does not get 4.4.latest version | Needs Feedback | 2011-12-23 |
History
Updated by Tobias Liebig 6 months ago
- Status changed from New to Needs Feedback
- Assignee set to Christian Weiske
I refactored the tx_caretaker_LatestVersionsHelper in my caretaker fork on Github: https://github.com/etobi/caretaker
It now uses the official JSON releases feed at get.typo3.org/json and should be much more staple.
Could you test if this issue is solved with that version? If yes, i can "pull request" it into the official repository.
Updated by Christian Weiske 4 months ago
Tobias, I have no idea why you think this issue is solved with your patch. It is not. It doesn't even remotely touch the file I mentioned.
Regarding your patch: I would never ever trust a different source about TYPO3 versions than typo3.org. It might be fine for you, but other people depend on those data and don't want to see their status monitors red when "typo3.causal.ch" is down or - worse - compromised.
Updated by Tobias Liebig 4 months ago
- Status changed from Needs Feedback to New
Tobias, I have no idea why you think this issue is solved with your patch. It is not. It doesn't even remotely touch the file I mentioned.
hum.. seems like i misread your issue. Sorry about that.
Could you, maybe, provide a patch for your suggestion. PHP's version_compare seems like a good choice. Should fit and it should be possible using a unit test to verify it's really fitting our version number names, too.
Regarding your patch: I would never ever trust a different source about TYPO3 versions than typo3.org. It might be fine for you, but other people depend on those data and don't want to see their status monitors red when "typo3.causal.ch" is down or - worse - compromised.
BTW: we just moved our repositories to https://github.com/TYPO3-Caretaker/
and the pending changes from my repository are already merged.
However, of course using "typo3.causal.ch" would not make much sense. This is why i changed/fixed the URL two minutes later in the next commit, using typo3.org: https://github.com/etobi/caretaker/commit/4e3a7946c4953667593b4d3987a5b682e191cf91
kind regards
tobias