ReStructured Text Infrastructurewiki.typo3.orgOfficial Documentation

Task #36631

Note that configuration files should follow the CGL

Added by Stefano Kowalke about 1 year ago. Updated 18 days ago.

Status:Resolved Start date:2012-04-26
Priority:Should have Due date:
Assignee:Chris topher % Done:

100%
Category:-
Target version:6.0.0
Votes: 0

Description

In our issue tracker [1] we have a report complaining about the violations in localconf.php. For me this file is not a normal PHP file in term of executable file. Its more an config file which is parsed by TYPO3 (read and write), so it not really necessary that this file follow the CGLs.

What do you think?

[1] #27728

Related issues

blocks PHP_CodeSniffer - Feature #27728: Standard-Settings in localconf.php are not valid On Hold 2011-06-28

Associated revisions

Revision dbda6969
Added by Chris topher 18 days ago

[TASK] Note that configuration files should follow the CGL

Add a note on the applicability of the CGLs to configuration files.

Change-Id: I52cc13fa10998c59b7ecbd1514e13471e1a6ec2b
Resolves: #36631
Reviewed-on: https://review.typo3.org/20593
Reviewed-by: Christopher
Tested-by: Christopher

History

#1
Updated by Philipp Gampe 8 months ago

localconf.php does not exits any more, but should follow CGL und the new LocalConfiguration.php should follow the CGL too.

#2
Updated by Chris topher 22 days ago

I would not put any major effort into localconf.php nowadays. However, I will document the behaviour for LocalConfiguration.php of TYPO3 6.0 and later.

LocalConfiguration.php should follow the CGL for the following reasons: It is generated out of FactoryConfiguration.php. This file is part of the Core, which itself must follow CGL. Additionally it is only to be processed and modified by the Core; the Core, which itself must follow CGL. AdditionalConfiguration.php should follow the CGL as well. Maybe it is not necessarily generated by the Core, but it belongs to the system in a way just like LocalConfiguration.php.

#3
Updated by Chris topher 18 days ago

  • Subject changed from Should localconf.php follow the CGL? to Note that configuration files should follow the CGL

#4
Updated by Gerrit Code Review 18 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20593

#5
Updated by Gerrit Code Review 18 days ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20593

#6
Updated by Chris topher 18 days ago

  • Assignee set to Chris topher

#7
Updated by Chris topher 18 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8
Updated by Chris topher 18 days ago

  • Target version set to 6.0.0

Also available in: Atom PDF