Bug #36751

Fluid unit test broken

Added by Marc Bastian Heinrichs about 1 year ago. Updated 5 months ago.

Status:Resolved Start date:2012-05-01
Priority:Must have Due date:
Assignee:Helmut Hummel % Done:

100%
Category:Fluid: Core
Target version:-
Complexity:
Votes: 0

Description

Since merge of http://git.typo3.org/TYPO3v4/CoreProjects/MVC/extbase.git?a=commit;h=bcdd9eb74e276f5062a714c89556471ca3266dc2 the unit test is broken
Tx_Fluid_Tests_Unit_Core_Widget_AbstractWidgetControllerTest::processRequestSetsWidgetConfiguration

Related issues

related to Extbase MVC Framework - Bug #38431: Unify the response implementations Rejected 2012-06-27
duplicated by Fluid - Bug #39170: PHPUnit tests broken in current master Closed 2012-07-22

Associated revisions

Revision cf54f334
Added by Tobias Liebig 10 months ago

[BUGFIX] Only set request for Web_Response

The current request is needed in Tx_Extbase_MVC_Web_Response to
distinguish between a cached or a non-cached request in
addAdditionalHeaderData() as the PageRenderer does not support USER_INTs
currently. This works fine is the ActionController is called with a
Web_Response, but causes an fatal error if a Cli_Response is in charge.

This fix and the $request member in Web_Response should be removed,
once the PageRenderer is fixed for USER_INTs. For now, this patch fixes
a fatal error in the fluid unit tests.

Change-Id: I56fabc3a51ce2c5192ab4488c817b938ed8797ca
Fixes: #36751
Releases: 6.0
Reviewed-on: http://review.typo3.org/12401
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1
Updated by Tobias Liebig 11 months ago

Solution 1 (by Bastian Weidelich in typo3-project-typo3v4mvc:

in Tx_Extbase_MVC_Controller_ActionController::processRequest, replace

$response->setRequest($request);

with

if ($response instanceof Tx_Extbase_MVC_Web_Response) {
    $response->setRequest($request);
}

Solution 2:

move setRequest from Tx_Extbase_MVC_Web_Response to the super class Tx_Extbase_MVC_Response as also suggested in #38431

In both cases:
Once the PageRenderer does work with USER_INTs (this is why the Web_Response needs the $request in ::addAdditionalHeaderData this workaround (and the $request member in Web_Response) could be removed again.

#2
Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12401

#3
Updated by Ingo Pfennigstorf 10 months ago

  • Assignee set to Helmut Hummel
  • Target version set to Extbase 6.0

Any Updates on this, Helmut?

#4
Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12401

#5
Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12401

#6
Updated by Tobias Liebig 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:cf54f33488c1cd663bcbb8b2421340233934e386.

#7
Updated by Anja Leichsenring 5 months ago

  • Project changed from Extbase MVC Framework to Fluid
  • Category changed from 959 to Fluid: Core
  • Target version deleted (Extbase 6.0)

Also available in: Atom PDF