Direct Mail

Hi.

First no problem, i just had the problem and found a solution, had to share :)

Actually i'm not sure if the foreach can be skipped or not. But will test it of course..

Will test your suggestion too, but cannot test this before monday at work.

When will next version be released?

Tomas Norre Mikkelsen wrote:

First no problem, i just had the problem and found a solution, had to share :)

of course, thanks for pointing the problem :)

Actually i'm not sure if the foreach can be skipped or not. But will test it of course..

yes, the foreach is not needed anymore :)

Hi,

I just tested with the array_flip() function, and there are challenges regarding the data structure.

The $plainlist = array() you are testing with have the "wrong" structure compared to the direct_mail data structure.

The array from direct_mail looks like this:

0 =>
array
'email' => string 'test0@domain.tld' (length=16)
'name' => string '' (length=0)
1 =>
array
'email' => string 'test1@domain.tld' (length=16)
'name' => string '' (length=0)
2 =>
array
'email' => string 'test2@domain.tld' (length=16)
'name' => string '' (length=0)
3 =>
array
'email' => string 'test3@domain.tld' (length=16)
'name' => string '' (length=0)
4 =>
array
'email' => string 'test4@domain.tld' (length=16)
'name' => string '' (length=0)

Compare that to your test array:

0 => 'test4@domain.tld' 
  1 => 'test5@domain.tld' 
  2 => 'test6@domain.tld' 
  3 => 'test7@domain.tld' 
  4 => 'test8@domain.tld'

That's the reason we have the foreach, because of the multidimensional array. So with the direct_mail data structure the array_flip is not the solution.

Hi Tomas,

yes, you're right. my solution only works with a one dimension array. but the array_map solution filters only array value with the exact same structure (email and name). Following example:

array(
  0 => array(
    'email' => 'test0@mail.com',
    'name' => 'test0'
  ),
  1 => array(
    'email' => 'test1@mail.com',
    'name' => 'test1'
  ),
  2 => array(
    'email' => 'test0@mail.com',
    'name' => 'test2'
  ),
  3 => array(
    'email' => 'test0@mail.com',
    'name' => 'test0'
  ),
);

the array_map solution only removes the fourth element. What about the third element? does it count as a duplicate?

Hi,

I get you point, but what is the idea about have one email register multiple times with different names?

In my opinion this should be controlled at submission not at filtering.