Change whitespaces in indentions into tabs
|Priority:||Should have||Due date:|
|Assignee:||Stefano Kowalke||% Done:||
|Target version:||Core - 6.0.0|
Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.
How to check?¶
I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:
phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/typo3/sysext/dbal
before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.
I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.
|related to Core - Task #36871: Change whitespaces in indentions into tabs||Resolved||2012-05-06|
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11021
Updated by Xavier Perseguers about 1 year ago
- Status changed from New to Resolved
- Target version set to 6.0.0
- % Done changed from 0 to 100