Task #36883
Change whitespaces in indentions into tabs (Sysext: Version)
| Status: | Closed | Start date: | 2012-05-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Stefano Kowalke | % Done: | 0% |
|
| Category: | Code Cleanup | |||
| Target version: | - | |||
| TYPO3 Version: | 4.7 | PHP Version: | 5.3 | |
| Votes: | 0 |
Description
Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.
How to check?¶
I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:
phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/typo3/sysext/version
before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.
I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.
Related issues
| related to Core - Task #36871: Change whitespaces in indentions into tabs | Resolved | 2012-05-06 |
History
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11025
Updated by Andy Grunwald 11 months ago
This change is already merged.
Gerrit does not change the status of this ticket.
Can someone close this?
Updated by Wouter Wolters 10 months ago
Can be closed.
Updated by Susanne Moog 10 months ago
- Status changed from Under Review to Closed