Bug #37139
Fix 2 CGL violations: FunctionCallArgumentSpacingNoSpaceBeforeEquals & FunctionCallArgumentSpacingNoSpaceAfterEquals
| Status: | Resolved | Start date: | 2012-05-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Roland Waldner | % Done: | 100% |
|
| Category: | Code Cleanup | |||
| Target version: | 6.0.0 | |||
| TYPO3 Version: | 6.0 | Complexity: | ||
| PHP Version: | 5.3 | |||
| Votes: | 0 |
Description
on metrics.typo3.org the violations drilldown says that is 1 violation against "FunctionCallArgumentSpacingNoSpaceAfterEquals" and 1 violation against "FunctionCallArgumentSpacingNoSpaceBeforeEquals": both in typo3/alt_shortcut.php.
this should be fixed.
after that i guess these 2 coding guidline sniffs could be activated in the CI-server jobs?
Associated revisions
[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.
on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.
this should be fixed.
after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?
Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.
on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.
this should be fixed.
after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?
Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11157
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11157
Updated by Anonymous about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset eb07a6c610ee60a2e3067d01bfeebfbc1343af9f.