Bug #37352

generateValueHash() should use getIdentifierByObject()

Added by Karsten Dambekalns 12 months ago. Updated 5 months ago.

Status:Under Review Start date:2012-05-21
Priority:Must have Due date:
Assignee:Karsten Dambekalns % Done:

0%

Category:Persistence
Target version:TYPO3 Flow Base Distribution - 2.1
PHP Version: Complexity:
Has patch:No FLOW3 version affected:Git 1.0
Votes: 0

Description

The generateValueHash() method only tries to use FLOW3_Persistence_Identifier directly, but should use getIdentifierByObject() to support custom identifier properties.


Related issues

related to TYPO3.Flow - Feature #37286: Include object properties in Value Object hash creation Closed 2012-05-18

History

Updated by Gerrit Code Review 12 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11598

Updated by Karsten Dambekalns 12 months ago

  • Target version changed from 1.1 beta 2 to 2.0 beta 1

Postponed because of possible side effects… Will need some more work.

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11722

Updated by Karsten Dambekalns 5 months ago

  • Target version changed from 2.0 beta 1 to 2.1

Also available in: Atom PDF