Bug #37385

Annotation of Validate and IgnoreValidation

Added by Carsten Bleicker about 1 year ago. Updated 12 months ago.

Status:Resolved Start date:2012-05-22
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:Validation
Target version:TYPO3 Flow Base Distribution - 1.1 beta 3
PHP Version: Complexity:
Has patch:No FLOW3 version affected:FLOW3 1.1.0 beta 1
Votes: 1 (View)

Description

I would expect that notation of Validate and IgnoreValidation is the same.
@FLOW3\Validate(argumentName="test"...) matches but @FLOW3\IgnoreValidation(argumentName="test") doesnt. i have to write
@FLOW3\IgnoreValidation("$test") or @FLOW3\IgnoreValidation(argumentName="$test").

The FLOW3\Validate does an ltrim of "$" wich the IgnoreValidation Annotation doesn't.

Associated revisions

Revision 4ae13b54
Added by Karsten Dambekalns about 1 year ago

[BUGFIX] Fix inconsistent Validate and IgnoreValidation behavior

The Validate annotation does an ltrim of "$" on the argument which the
IgnoreValidation annotation did not do. This change makes the two behave
the same by adding that trim to IgnoreValidation as well.

Change-Id: I058c07e7c446f9adbd46d8236b9fc4689abb74b8
Fixes: #37385
Releases: 1.1, 1.2

Revision 24485a77
Added by Karsten Dambekalns about 1 year ago

[BUGFIX] Fix inconsistent Validate and IgnoreValidation behavior

The Validate annotation does an ltrim of "$" on the argument which the
IgnoreValidation annotation did not do. This change makes the two behave
the same by adding that trim to IgnoreValidation as well.

Change-Id: I058c07e7c446f9adbd46d8236b9fc4689abb74b8
Fixes: #37385
Releases: 1.1, 1.2

History

#1
Updated by Karsten Dambekalns about 1 year ago

  • Category changed from AOP to Validation
  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns
  • Target version set to 1.1

#2
Updated by Karsten Dambekalns about 1 year ago

  • Target version changed from 1.1 to 1.1 RC1

#3
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#4
Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#5
Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#6
Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#7
Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#8
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11751

#9
Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11604

#10
Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11751

#11
Updated by Karsten Dambekalns about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12
Updated by Karsten Dambekalns 12 months ago

  • Target version changed from 1.1 RC1 to 1.1 beta 3

Also available in: Atom PDF