TYPO3.Party

currently,

1 abstract class AbstractParty {
2 
3     /**
4      * @var \Doctrine\Common\Collections\Collection<\TYPO3\FLOW3\Security\Account>
5      * @ORM\OneToMany(mappedBy="party")
6      */
7     protected $accounts;

In very common use cases where a Party is created during a registration process, both the Party and the Account has to be persisted manually using the (injected) repository each.

I suggest to add a cascade=persist to that property, like

1 abstract class AbstractParty {
2 
3     /**
4      * @var \Doctrine\Common\Collections\Collection<\TYPO3\FLOW3\Security\Account>
5      * @ORM\OneToMany(mappedBy="party", cascade="persist")
6      */
7     protected $accounts;

This would make the following steps be sufficient for a person/party creation:

1 $person = new \TYPO3\Party\Domain\Model\Person();
2 $person->setPersonName(new \TYPO3\Party\Domain\Model\PersonName('', $firstName, '', $lastName));
3 
4 $account = $this->accountFactory->createAccountWithPassword($email, $password);
5 $person->addAccount($account);
6 
7 $this->partyRepository->add($person);

...do you agree?