Bug #37878

Task #44341: Multi Language Compatibility

Backend: Column relation lost after translation

Added by Michael Birchler 11 months ago. Updated about 1 month ago.

Status:Closed Start date:2012-06-11
Priority:Must have Due date:
Assignee:Jo Hasenau % Done:

0%

Category:Language and Translation Spent time: -
Target version:-
TYPO3 Version:4.5 PHP Version:
Votes: 5 (View)

Description

The column relation of the children content elements of a gridelement gets lost when you translate a gridelement.

Step by step:

Default language view:

Translate gridelement to english:

Column relation lost:

step1.png (15 kB) Michael Birchler, 2012-06-11 09:39

step2.png (15.8 kB) Michael Birchler, 2012-06-11 09:39

step3.png (17 kB) Michael Birchler, 2012-06-11 09:39

0001-gridelements.patch (1.5 kB) Alexander Schnitzler, 2012-07-02 18:08

37878.diff (940 Bytes) Michael Birchler, 2012-07-05 10:42

de.jpg - lang 0 (65.5 kB) Maik Peuser, 2012-11-21 18:32

en.jpg - lang 1 (40.8 kB) Maik Peuser, 2012-11-21 18:32


Related issues

related to Grid Elements - Feature #37876: Backend: Pagemodul language view Resolved 2012-06-11
related to Grid Elements - Bug #36910: Problems with translation Resolved 2012-05-07
related to Grid Elements - Bug #35997: Copy & paste into grid columns does not work for translat... Resolved 2012-04-13

History

Updated by Michael Birchler 11 months ago

TYPO3: 4.6.9
Gridelements: 1.3.12

Updated by Jo Hasenau 11 months ago

  • Status changed from New to Accepted

The original sponsor didn't need translations so there are still lots of language related things to do.
But actually this is not a bug but a missing feature.

Updated by Michael Birchler 11 months ago

Is there a schedule when the language features gets implemented? Maybe we could provide developement work or would you prefer a sponsor?

Updated by Jo Hasenau 11 months ago

  • Priority changed from Should have to Must have

Currently we've got a lot of feature requests and bug reports, so both - sponsoring and manpower - would be highly appreciated.
There is no schedule yet, since there is still no decision about implementing grid elements into the 6.0 core and therefor there's no need to hurry ;-)

IMHO it will be best to provide a stable extension including all necessary features before implementing parts of it into the core while providing the rest of it as a sysext.
Therefor we will still need some additional hooks in the core, especially when it comes to language handling or showing things properly in the list module.
Since we will get a lot of breaking changes and new features with 6.0, maybe it would be wise to wait until 6.1 or so, but we should prepare the 6.0 core already to be able to connect to the features we are going to implement.

BTW: Sponsors will get an official bill by our company, so it will be easier to handle than the usual donations.

Updated by Heiko Kromm 11 months ago

Any chance to get this feature until end of July 2012 if we sponsor it?

Updated by Alexander Schnitzler 11 months ago

Ich habe das Problem jetzt mal lokalisiert und der Patch anbei behebt das Problem.

Die Frage ist allerdings ob dadurch irgendwas kaputt geht. Ich selbst kann das nicht beurteilen, die Extension läuft allerdings super mit der Änderung.

Eventuell kann das mal jemand, der sich auskennt, evaluieren.

Liebe Grüße,
Alexander

Updated by Jo Hasenau 11 months ago

Just for the people who don't speak German ;-)

The patch above should fix the problem. We are currently evaluating possible side effects, since the setting that will be removed by this patch had been introduced on purpose (I guess)

@Heiko: It seems we will be able to fix it until end of July - still some sponsoring might speed up things a bit ;-)

Updated by Jo Hasenau 11 months ago

Well - some bad news: The patch breaks pasting after grid children in grid columns with a value higher than 0 :-(

So it seems we have to dig a bit deeper to improve this fix.

Updated by Jo Hasenau 11 months ago

  • Category set to Language and Translation

Updated by Michael Birchler 11 months ago

New patch to fix the column relation problem.

Updated by Markus Kobligk 10 months ago

The new patch works fine for me, no side effects recognized yet.

Thanks Michael!

Updated by Max Roesch 10 months ago

Applied the both patches. So far it seems to work. Haven't noticed any negative side effects yet.

Thanks Michael & Alexander

Updated by Bas van Beek 10 months ago

Works perfect as long as you do both patches.

In ext_tables.php

Replace: $TCA['tt_content']['ctrl']['copyAfterDuplFields'] .= ',tx_gridelements_container,tx_gridelements_columns';
With: $TCA['tt_content']['ctrl']['copyAfterDuplFields'] .= ',tx_gridelements_container';

In class.tx_gridelements_tcemainhook.php

On line 108 Add:

// is localize?
$cmd = t3lib_div::_GP('cmd');
$localize = intval($cmd['tt_content'][$fieldArray['tx_gridelements_container']]['localize']);
$orignalUid = intval($fieldArray['t3_origuid']);
if($localize && $orignalUid) {
$originalColumn = $GLOBALS['TYPO3_DB']->exec_SELECTgetSingleRow(
'tx_gridelements_columns',
'tt_content',
'uid=' . $orignalUid
);
if(!empty($originalColumn['tx_gridelements_columns'])) {
$fieldArray['tx_gridelements_columns'] = $originalColumn['tx_gridelements_columns'];
}
}

Great work!

Updated by Max Roesch 9 months ago

Any plans to merge this to the current trunk soon?

Updated by Maik Peuser 6 months ago

This patch works fine in Live-Stage.
If you translate an element within a workspace it still looses its positions.

We can reproduce it if you have a single page with language uid=0. Some regular elements, some grid containers with 2 columns.

If you translate the page, copy all elements to new english version all elements which are NOT Inside a grid container are saved correctly. The grid container itself is also saved correct, but instead of the child elements appearing on english version, they are shown inside the grid container (orig uid). Screenshot attached.

Updated by Jo Hasenau 6 months ago

  • TYPO3 Version set to 4.7

Did you test it with or without the ext_tables.php patch?
Since this patch breaks pasting after grid children in grid columns with a value higher than 0, we still hadn't got a solution, unless you didn't need this patch to make things work.

Updated by Maik Peuser 6 months ago

i tried it with the above patch. it only works for us in live-workspace, not in draft.

Updated by Jo Hasenau 6 months ago

So the patch fixes your individual problem but still we would run into the same problems while copying grid children after other grid children in columns with colPos > 0.

After all it does not seem that trivial, which is why we calculated about 2000,- € for sponsoring this feature/bugfix.

BTW: We already found a sponsor at http://www.startnext.de/en/typo3-grid-elements-2-0, but since we still didn't reach the overall goal, we can not make sure yet, when this will actually be done.

Updated by Jo Hasenau 5 months ago

  • Assignee set to Jo Hasenau
  • TYPO3 Version changed from 4.7 to 4.5

Updated by Jo Hasenau 4 months ago

  • Status changed from Accepted to Resolved

Updated by Jo Hasenau 4 months ago

  • Parent task set to #44341

Updated by Arne-Kolja Bachstein about 1 month ago

Is this resolved in 1.4 final yet, or do I have to get the currect trunk? I think I'm having the same problem with 1.4 final, too.

  • TYPO3 4.7.10
  • Grid Elements 1.4.0 final
  • Database compared okay
  • Workspaces activated, but only working in live workspace for now

Updated by Jo Hasenau about 1 month ago

I removed my former statement, since it was completely unrelated to this issue.
Actually the stuff Oliver has been working has been related to translations AND workspaces.

I tested the issue described here again and could not find any problems with 1.4.0 final running on the latest TYPO3 4.7 without any additional patches.

Updated by Arne-Kolja Bachstein about 1 month ago

Sorry, you're right. My problem was of a different kind. A mix of l20n settings and errors that occurred before upgrading to 1.4.0. 1.4.0 seems to work fine :-)

Updated by Jo Hasenau about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF