Task #38333
Cleanup: Useless method overriding in t3lib_spritemanager_SimpleHandler
| Status: | Resolved | Start date: | 2012-06-23 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Andy Grunwald | % Done: | 100% |
|
| Category: | Code Cleanup | |||
| Target version: | 6.0.0 | |||
| TYPO3 Version: | 6.0 | Complexity: | easy | |
| PHP Version: | ||||
| Votes: | 0 |
Description
In t3lib_spritemanager_SimpleHandler the method __construct just calls his parent
/**
* constructor just init's the temp-file-name
* @return void
*/
public function __construct() {
parent::__construct();
}
This is quite useless, because due OOP, the parent method (t3lib_spritemanager_AbstractHandler::__construct) is called, if t3lib_spritemanager_SimpleHandler does not provide a local / override method.
Associated revisions
[TASK] Remove empty constructor from t3lib_spritemanager_SimpleHandler
An empty constructor just calling parent is not needed, because parent
constructors are always called automatically.
Change-Id: I86818458540dd85709619f0d0ab21efa266e079b
Fixes: #38333
Releases: 6.0
Reviewed-on: http://review.typo3.org/12312
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[TASK] Remove empty constructor from t3lib_spritemanager_SimpleHandler
An empty constructor just calling parent is not needed, because parent
constructors are always called automatically.
Change-Id: I86818458540dd85709619f0d0ab21efa266e079b
Fixes: #38333
Releases: 6.0
Reviewed-on: http://review.typo3.org/12312
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
Updated by Gerrit Code Review 11 months ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12312
Updated by Gerrit Code Review 11 months ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12312
Updated by Andy Grunwald 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset fb4f4fc5b4df77162f51106bd4ff8a47ba43b88e.