Feature #38337

Include Generic.CodeAnalysis.UnnecessaryFinalModifier for FLOW3 / TYPO3v4

Added by Andy Grunwald 12 months ago. Updated 9 months ago.

Status:Closed Start date:2012-06-23
Priority:Should have Due date:
Assignee:Andy Grunwald % Done:

100%
Category:CodeAnalysis Spent time: -
Target version:0.0.4
Branch:v4 + v5 Tags:
Votes: 0

Description

The sniff Generic.CodeAnalysis.UnnecessaryFinalModifier could be useful for both standards (TYPO3v4 / FLOW3).
This sniff detects final modifier which are not needed.

Subtasks

Task #38338: Document Generic.CodeAnalysis.UnnecessaryFinalModifier in...ClosedAndy Grunwald

Associated revisions

Revision ad43f48b
Added by Andy Grunwald 11 months ago

[TASK] Activate Generic.CodeAnalysis.UnnecessaryFinalModifier for FLOW3 / TYPO3v4

The sniff Generic.CodeAnalysis.UnnecessaryFinalModifier
could be useful for both standards (TYPO3v4 / FLOW3).
This sniff detects final modifier which are not needed.

Change-Id: Ibd66e566b5d9f8fbab59dcf8f8622eb31d074aff
Fixes: #38337
Releases: 0.0.4

History

#1
Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12316

#2
Updated by Andy Grunwald 12 months ago

  • Status changed from New to Under Review

#3
Updated by Stefano Kowalke 11 months ago

I added the sniff to the nightly build job. Lets have a look how much violations are in the core.

#4
Updated by Stefano Kowalke 11 months ago

  • Status changed from Under Review to On Hold

#5
Updated by Andy Grunwald 11 months ago

  • Subject changed from Activate Generic.CodeAnalysis.UnnecessaryFinalModifier for FLOW3 / TYPO3v4 to Include Generic.CodeAnalysis.UnnecessaryFinalModifier for FLOW3 / TYPO3v4
  • Status changed from On Hold to Under Review

Sorry for the wrong description.
Activation don`t mean in jenkins at this case.
Including this sniff into our standard is the right title.

Please have a look at the patch request

#6
Updated by Stefano Kowalke 11 months ago

A sorry. I just want merge the CS but there is an path conflict. Can you solve it and push it again. You can also merge it.

#7
Updated by Andy Grunwald 11 months ago

Just catch the patch fro gerrit and rebase it.
At the moment, i don`t have a configured git enviroment here.
Rebase it or i will do it at sunday.

#8
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12316

#9
Updated by Andy Grunwald 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10
Updated by Stefano Kowalke 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF