Feature #38339

Include Generic.CodeAnalysis.ForLoopWithTestFunctionCall for FLOW3 / TYPO3v4

Added by Andy Grunwald 12 months ago. Updated 9 months ago.

Status:Closed Start date:2012-06-23
Priority:Should have Due date:
Assignee:Andy Grunwald % Done:

100%
Category:CodeAnalysis Spent time: -
Target version:0.0.4
Branch:v4 + v5 Tags:
Votes: 0

Description

The sniff Generic.CodeAnalysis.ForLoopWithTestFunctionCall could be useful for both standards (TYPO3v4 / FLOW3).

This sniff detects function calls in loops.
This kind of coding could be decrease the performance, because the function is called every duration of the loop.

Subtasks

Task #38340: Document Generic.CodeAnalysis.ForLoopWithTestFunctionCall...ClosedAndy Grunwald

Associated revisions

Revision d572daef
Added by Andy Grunwald 11 months ago

[FEATURE] Activate Generic.CodeAnalysis.ForLoopWithTestFunctionCall for FLOW3 / TYPO3v4

The sniff Generic.CodeAnalysis.ForLoopWithTestFunctionCallcould
be useful for both standards (TYPO3v4 / FLOW3).

This sniff detects function calls in loops.
This kind of coding could be decrease the performance,
because the function is called every duration of the loop.

Change-Id: Iac6c7ae52069c9b163ebd120885841115073d3e9
Fixes: #38339
Releases: 0.0.4

History

#1
Updated by Andy Grunwald 12 months ago

  • Tracker changed from Task to Feature

#2
Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12317

#3
Updated by Andy Grunwald 12 months ago

  • Status changed from New to Under Review

#4
Updated by Stefano Kowalke 11 months ago

  • Status changed from Under Review to On Hold

There are 50 violations today for this sniff. So we must get rid of it before activate the sniff. Please note here if the core is cleaned up.

#5
Updated by Andy Grunwald 11 months ago

  • Status changed from On Hold to Under Review

This ticket is about including this sniff in our standard.
not about the activation in jenkins

Please have a look at the patch request

#6
Updated by Andy Grunwald 11 months ago

  • Subject changed from Activate Generic.CodeAnalysis.ForLoopWithTestFunctionCall for FLOW3 / TYPO3v4 to Include Generic.CodeAnalysis.ForLoopWithTestFunctionCall for FLOW3 / TYPO3v4

#7
Updated by Stefano Kowalke 11 months ago

A sorry. I just want merge the CS but there is an path conflict. Can you solve it and push it again. You can also merge it.

#8
Updated by Andy Grunwald 11 months ago

Just catch the patch fro gerrit and rebase it.
At the moment, i don`t have a configured git enviroment here.
Rebase it or i will do it at sunday.

#9
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12317

#10
Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12317

#11
Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12317

#12
Updated by Andy Grunwald 11 months ago

  • Status changed from Under Review to Resolved

Merged :)

#13
Updated by Stefano Kowalke 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF