Suggestion #38368
Record list on pages flexible width
| Status: | Closed | Start date: | 2012-06-25 | ||
|---|---|---|---|---|---|
| Priority: | Could have | Due date: | |||
| Assignee: | - | % Done: | 90% |
||
| Category: | Usability | ||||
| Target version: | - | ||||
| Tags: | |||||
| Votes: | 0 |
Description
Make the record list on pages flexible, now its all pressed into 480 Pixels hardcoded:
typo3/sysext/cms/layout/class.tx_cms_layout.php:
- <table border="0" cellpadding="1" cellspacing="2" width="480" class="typo3-page-stdlist">
+<table border="0" cellpadding="1" cellspacing="2" class="typo3-page-stdlist">
Related issues
| related to Core - Bug #38949: Record list in Page Module rendered without section header | Resolved | 2012-07-14 |
History
Updated by Noel Bossart 11 months ago
- File class.tx_cms_layout.php.diff added
Updated by Jens Hoffmann 11 months ago
- Status changed from New to Needs Feedback
- Priority changed from Should have to Could have
Can you Attach two Screenshots (Before-After), please.
Greez Jens
Updated by Noel Bossart 11 months ago
- File before.png added
- File before2.png added
- File after.png added
- File after2.png added
Updated by Jens Hoffmann 11 months ago
THX
Updated by Noel Bossart 11 months ago
One could also make it 100% – but this is not suitable in other situations. Or set a min-width with – both would be better in css than hardcoded.
Updated by Jens Hoffmann 11 months ago
Could you attach a bit more padding ~3px per cell. padding: 1px, 3px, 1px, 3px;
Looks really compressed - which isn't good.
Greez Jens
Updated by Noel Bossart 11 months ago
I wouldn't know where to add this, sorry. Would have to be done in CSS.
Updated by Felix Kopp 11 months ago
Hi Noel, good catch. Also the table headers should be of type typo3-dblist in relation to http://forge.typo3.org/issues/28188#note-2.
Do you know how to push patches to gerrit review server?
Please find tipps here http://wiki.typo3.org/Contribution_Walkthrough.
Also I could push your patches I you are not that deep into the core structure and/or git.
Just comment.
Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12709
Updated by Jens Hoffmann 11 months ago
Can someone post screens here?
How douse it look like after the patch?
Updated by Felix Kopp 9 months ago
- File 1-page-module-before.png added
- File 2-list-module-baseline.png added
- File 3-page-module-MOCKUP.jpg added
Hi all, added a comment on Gerrit.
I would like to unify the style of the table within Page module to *exactly the style of tables within the List module.
Actually technically the Page module's list is a database list with predefined columns as in List module - so there should be no visual distinctions as well.
Database table from the page module without styling - before:
Same table displayed within List module as:
So the Page module should look like the List module — but based on the current implementation and limitions:
Updated by Gerrit Code Review 9 months ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12709
Updated by Gerrit Code Review 9 months ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12709
Updated by Gerrit Code Review 9 months ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12709
Updated by Michael Stucki 9 months ago
- % Done changed from 0 to 90
Seems like this was successfully merged. However, just like myself, Gerrit is not able to close the task.
Can someone please take care of it?
Updated by Felix Kopp 8 months ago
This issue can be closed the underlying task is resolved and successfully merged in master.