Bug #38653

RTE: Words containing special characters not added to personal dictionary

Added by Gerhard Rupp 12 months ago. Updated 8 months ago.

Status:Resolved Start date:2012-07-04
Priority:Must have Due date:
Assignee:Stanislas Rolland % Done:

100%
Category:rtehtmlarea
Target version:4.5.20
TYPO3 Version:4.5 Complexity:
PHP Version:5.3
Votes: 0

Description

Words containing special characters (f. e. German umlauts) can´t be added to the user´s personal dictionary.

Related issues

duplicates Core - Bug #29685: Spellchecker is not able to add words with german umlauts... Resolved 2011-09-12

Associated revisions

Revision 31bef4e3
Added by Stanislas Rolland 12 months ago

[BUGFIX] Words with special characters not added to personal dictionary

Problem: Words containing special characters (f. e. German umlauts)
can´t be added to the user´s personal dictionary.
Solution: Work around Aspell issue.

Change-Id: I4382cabc8d4d5190d5c27a0bcdb4ab212b2855eb
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38653
Reviewed-on: http://review.typo3.org/12679
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Revision fe5b5a1e
Added by Stanislas Rolland 11 months ago

[BUGFIX] Words with special characters not added to personal dictionary

Problem: Words containing special characters (f. e. German umlauts)
can´t be added to the user´s personal dictionary.
Solution: Work around Aspell issue.

Change-Id: I4382cabc8d4d5190d5c27a0bcdb4ab212b2855eb
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38653
Reviewed-on: http://review.typo3.org/12679
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Revision 04067c66
Added by Stanislas Rolland 8 months ago

[BUGFIX] Words with special characters not added to personal dictionary

Problem: Words containing special characters (f. e. German umlauts)
can´t be added to the user´s personal dictionary.
Solution: Work around Aspell issue.

Change-Id: I23a8a36d56b12cc14f32b0a30443c62d6e11bd5a
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38653
Reviewed-on: http://review.typo3.org/12680
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Revision 8186fb02
Added by Stanislas Rolland 8 months ago

[BUGFIX] Words with special characters not added to personal dictionary

Problem: Words containing special characters (f. e. German umlauts)
can´t be added to the user´s personal dictionary.
Solution: Work around Aspell issue.

Change-Id: I0423993e335a253fc1450aeec8357c5bcb6da236
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38653
Reviewed-on: http://review.typo3.org/15466
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Revision d39dbde6
Added by Stanislas Rolland 8 months ago

[BUGFIX] Words with special characters not added to personal dictionary

Problem: Words containing special characters (f. e. German umlauts)
can´t be added to the user´s personal dictionary.
Solution: Work around Aspell issue.

Change-Id: I0652c29d1f1edd2b86f108075fae985241a9b79e
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38653
Reviewed-on: http://review.typo3.org/15467
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

History

#1
Updated by Stanislas Rolland 12 months ago

  • Category set to rtehtmlarea

#2
Updated by Stanislas Rolland 12 months ago

  • Status changed from New to Needs Feedback
  • Assignee set to Stanislas Rolland

Is the TYPO3 backend utf-8-encoded?

#3
Updated by Gerhard Rupp 12 months ago

Yes, it is.
I found a similar bug report at http://lists.typo3.org/pipermail/typo3-project-rte/2012-January/002322.html

Maybe this could help.

#4
Updated by Gerhard Rupp 12 months ago

Are you sure that fwrite is capable of writing utf-8 without encoding?

#5
Updated by Stanislas Rolland 12 months ago

Gerhard Rupp wrote:

Are you sure that fwrite is capable of writing utf-8 without encoding?

Well, the word is correctly written in the temp file.

#6
Updated by Stanislas Rolland 12 months ago

Gerhard Rupp wrote:

Yes, it is. I found a similar bug report at http://lists.typo3.org/pipermail/typo3-project-rte/2012-January/002322.html

Maybe this could help.

This will not work in the general case.

#7
Updated by Stanislas Rolland 12 months ago

In think that the problem is that Aspell expects the word to be in the same charset as the dictionary being used. I am trying to find how to know in what charset the dictionary is encoded.

#8
Updated by Stanislas Rolland 12 months ago

  • Subject changed from Words containing special characters can´t be added to personal dictionary to RTE: Words containing special characters not added to personal dictionary

#9
Updated by Gerrit Code Review 12 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12679

#10
Updated by Stanislas Rolland 12 months ago

This is now fixed in master.

I think this is an Aspell issue. Here is the work around:
- before submitting additions to the personal word list or to the personal replacement pairs, access the main dictionary currently in use and retrieve the encoding specified in the file;
- convert the additions to the personal word list or to the personal replacement pairs to the encoding of the main dictionary.

The above will work only if the personal dictionaries are utf-8-encoded. Therefore, before submitting any request to Aspell, read the personal dictionary files and ensure that the encoding option is set to utf-8. If not, set the option to utf-8 and update the files.

Now need to backport to the stable releases.

#11
Updated by Stanislas Rolland 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12
Updated by Stanislas Rolland 12 months ago

  • Status changed from Resolved to Accepted
  • Target version set to 4.5.18

#13
Updated by Gerrit Code Review 12 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12680

#14
Updated by Stanislas Rolland 12 months ago

Please test this change on TYPO3 4.5: http://review.typo3.org/12680

#15
Updated by Gerhard Rupp 11 months ago

I can confirm that this patch works on a windows server on TYPO3 4.5.17.

#16
Updated by Stanislas Rolland 11 months ago

  • Status changed from Under Review to Resolved

#17
Updated by Gerhard Rupp 10 months ago

This patch seems not to be included in TYPO3 4.5.18.

#18
Updated by Stanislas Rolland 8 months ago

  • Status changed from Resolved to Under Review
  • Target version changed from 4.5.18 to 4.5.20

#19
Updated by Stanislas Rolland 8 months ago

  • Status changed from Under Review to Resolved

#20
Updated by Gerrit Code Review 8 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15466

#21
Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15467

#22
Updated by Stanislas Rolland 8 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF