Bug #38674
FLOW3 Coding Style Convention Check fails in Copyright and initStorageObjects
| Status: | Accepted | Start date: | 2012-07-05 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | Code Creation | |||
| Target version: | 6.0 | |||
| Votes: | 0 |
Description
When checking an new built extension against the FLOW3 Coding Style Convention the Test fails several times:
When providing Persons to for inclusion in ext_emconf the Copyright notice gets an extra Newline after the Year Notice with spaces at the end of line.
Otherwise the Year notice has an extra space at the end.
Also the constructor contains a malformed comment with wrong indention.
Furthermore the function initStorageObjects in Models who relate to two or more other models via m:n-relations contains an extra newline followed by tab-spaces after each non-last instantiation of Tx_Extbase_Persistence_ObjectStorage.
History
Updated by Nico de Haen 11 months ago
- Status changed from New to On Hold
- Target version set to 6.0
The superfluous spaces and new lines are coming from FLUID which is not really usable (an invented for) to create PHP code.
You mostly have to choice between really ugly and unreadable templates (almost the whole template in one line) or these superfluous lines in the resulting code.
I already use trim and remove double linebreaks (which is the reason why the indent of the comment is removed) at many places...
Not yet shure, how to solve this.
The wrong indents should disappear with the new ExtensionBuilder, which uses another templating for PHP files
Updated by Nico de Haen 11 months ago
- Status changed from On Hold to Accepted