Task #38740
Fix CGL violations against Squiz.WhiteSpace.LogicalOperatorSpacing
| Status: | Resolved | Start date: | 2012-07-07 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Andy Grunwald | % Done: | 100% |
|
| Category: | Code Cleanup | |||
| Target version: | 6.0.0 | |||
| TYPO3 Version: | 4.7 | Complexity: | no-brainer | |
| PHP Version: | ||||
| Votes: | 0 |
Description
FILE: ...velopment/TYPO3/typo3_src-git/t3lib/js/extjs/ExtDirect.StateProvider.js -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 265 | ERROR | Expected 1 space before logical operator; 2 found -------------------------------------------------------------------------------- FILE: .../andygrunwald/Development/TYPO3/typo3_src-git/t3lib/jsfunc.evalfield.js -------------------------------------------------------------------------------- FOUND 18 ERROR(S) AFFECTING 4 LINE(S) -------------------------------------------------------------------------------- 101 | ERROR | Expected 1 space before logical operator; 0 found 101 | ERROR | Expected 1 space after logical operator; 0 found 102 | ERROR | Expected 1 space before logical operator; 0 found 102 | ERROR | Expected 1 space after logical operator; 0 found 102 | ERROR | Expected 1 space before logical operator; 0 found 102 | ERROR | Expected 1 space after logical operator; 0 found 330 | ERROR | Expected 1 space before logical operator; 0 found 330 | ERROR | Expected 1 space after logical operator; 0 found 330 | ERROR | Expected 1 space before logical operator; 0 found 330 | ERROR | Expected 1 space after logical operator; 0 found 330 | ERROR | Expected 1 space before logical operator; 0 found 330 | ERROR | Expected 1 space after logical operator; 0 found 372 | ERROR | Expected 1 space before logical operator; 0 found 372 | ERROR | Expected 1 space after logical operator; 0 found 372 | ERROR | Expected 1 space before logical operator; 0 found 372 | ERROR | Expected 1 space after logical operator; 0 found 372 | ERROR | Expected 1 space before logical operator; 0 found 372 | ERROR | Expected 1 space after logical operator; 0 found -------------------------------------------------------------------------------- FILE: ...ald/Development/TYPO3/typo3_src-git/typo3/sysext/em/res/js/ux/jslint.js -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 2834 | ERROR | Expected 1 space before logical operator; 2 found -------------------------------------------------------------------------------- FILE: ...pment/TYPO3/typo3_src-git/typo3/sysext/rtehtmlarea/htmlarea/htmlarea.js -------------------------------------------------------------------------------- FOUND 2 ERROR(S) AFFECTING 2 LINE(S) -------------------------------------------------------------------------------- 886 | ERROR | Expected 1 space before logical operator; 2 found 4317 | ERROR | Expected 1 space after logical operator; 2 found -------------------------------------------------------------------------------- FILE: ...t/typo3/sysext/rtehtmlarea/htmlarea/plugins/ContextMenu/context-menu.js -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 114 | ERROR | Expected 1 space before logical operator; 2 found -------------------------------------------------------------------------------- FILE: ...src-git/typo3/sysext/rtehtmlarea/htmlarea/plugins/UndoRedo/undo-redo.js -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 135 | ERROR | Expected 1 space before logical operator; 2 found -------------------------------------------------------------------------------- FILE: ...o3_src-git/typo3/sysext/statictemplates/media/scripts/jsfunc.foldout.js -------------------------------------------------------------------------------- FOUND 8 ERROR(S) AFFECTING 3 LINE(S) -------------------------------------------------------------------------------- 30 | ERROR | Expected 1 space before logical operator; 0 found 30 | ERROR | Expected 1 space after logical operator; 0 found 31 | ERROR | Expected 1 space before logical operator; 0 found 31 | ERROR | Expected 1 space after logical operator; 0 found 32 | ERROR | Expected 1 space before logical operator; 0 found 32 | ERROR | Expected 1 space after logical operator; 0 found 32 | ERROR | Expected 1 space before logical operator; 0 found 32 | ERROR | Expected 1 space after logical operator; 0 found -------------------------------------------------------------------------------- FILE: ..._src-git/typo3/sysext/statictemplates/media/scripts/jsfunc.layermenu.js -------------------------------------------------------------------------------- FOUND 26 ERROR(S) AFFECTING 7 LINE(S) -------------------------------------------------------------------------------- 99 | ERROR | Expected 1 space before logical operator; 0 found 99 | ERROR | Expected 1 space after logical operator; 0 found 100 | ERROR | Expected 1 space before logical operator; 0 found 100 | ERROR | Expected 1 space after logical operator; 0 found 101 | ERROR | Expected 1 space before logical operator; 0 found 101 | ERROR | Expected 1 space after logical operator; 0 found 101 | ERROR | Expected 1 space before logical operator; 0 found 101 | ERROR | Expected 1 space after logical operator; 0 found 101 | ERROR | Expected 1 space before logical operator; 0 found 101 | ERROR | Expected 1 space after logical operator; 0 found 102 | ERROR | Expected 1 space before logical operator; 0 found 102 | ERROR | Expected 1 space after logical operator; 0 found 102 | ERROR | Expected 1 space before logical operator; 0 found 102 | ERROR | Expected 1 space after logical operator; 0 found 102 | ERROR | Expected 1 space before logical operator; 0 found 102 | ERROR | Expected 1 space after logical operator; 0 found 173 | ERROR | Expected 1 space before logical operator; 0 found 173 | ERROR | Expected 1 space after logical operator; 0 found 173 | ERROR | Expected 1 space before logical operator; 0 found 173 | ERROR | Expected 1 space after logical operator; 0 found 174 | ERROR | Expected 1 space before logical operator; 0 found 174 | ERROR | Expected 1 space after logical operator; 0 found 174 | ERROR | Expected 1 space before logical operator; 0 found 174 | ERROR | Expected 1 space after logical operator; 0 found 197 | ERROR | Expected 1 space before logical operator; 0 found 197 | ERROR | Expected 1 space after logical operator; 0 found -------------------------------------------------------------------------------- Time: 06:59, Memory: 106.00Mb
Associated revisions
[TASK] Fix CGL violations against LogicalOperatorSpacing
In the TYPO3 core and two system extensions, there are some
CGL violations against Squiz.WhiteSpace.LogicalOperatorSpacing.
Change-Id: I63d345b5a1f9024938574467f90d4d2662abe944
Fixes: #38740
Releases: 6.0
Reviewed-on: http://review.typo3.org/12701
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
[TASK] Fix CGL violations against LogicalOperatorSpacing
In the TYPO3 core and two system extensions, there are some
CGL violations against Squiz.WhiteSpace.LogicalOperatorSpacing.
Change-Id: I63d345b5a1f9024938574467f90d4d2662abe944
Fixes: #38740
Releases: 6.0
Reviewed-on: http://review.typo3.org/12701
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
History
Updated by Gerrit Code Review 11 months ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12701
Updated by Andy Grunwald 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset bc42bf17cc4df909da6dfb513f31b126d45721a1.